Skip to content

Conversation

@codope
Copy link
Member

@codope codope commented Jan 6, 2022

What is the purpose of the pull request

  • Add top level INIDEX action type.
  • Add supporting methods in HoodieTimeline.
  • Add index commit metadata which contains index plan.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@codope codope force-pushed the HUDI-3173-index-action branch 2 times, most recently from b2d14ae to 6c1c194 Compare January 17, 2022 05:37
@nsivabalan nsivabalan self-assigned this Jan 17, 2022
@nsivabalan
Copy link
Contributor

@codope : let me know once the patch is up for review.

@codope codope force-pushed the HUDI-3173-index-action branch from 6c1c194 to bae7919 Compare January 18, 2022 05:12
Fix timeline tests

Make MetadataPartitionType#all generic

Add instant info to plan and address review comments
@codope codope force-pushed the HUDI-3173-index-action branch from bae7919 to 8d94449 Compare January 21, 2022 11:52
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope
Copy link
Member Author

codope commented Jan 28, 2022

Closing it in favor of #4693 which has the core functionality and all comments from this PR addressed.

@codope codope closed this Jan 28, 2022
"int",
"null"
],
"default": 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the default version be 0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants