[HUDI-2477] Removing rollbacks instants from timeline for restore operation#4518
Merged
codope merged 1 commit intoapache:masterfrom Jan 10, 2022
Merged
[HUDI-2477] Removing rollbacks instants from timeline for restore operation#4518codope merged 1 commit intoapache:masterfrom
codope merged 1 commit intoapache:masterfrom
Conversation
nsivabalan
force-pushed
the
restore_rollback
branch
from
2b82de3 to
108b27f
Compare
Collaborator
codope
approved these changes
Jan 10, 2022
nsivabalan
added a commit
that referenced
this pull request
Jan 11, 2022
5 tasks
nsivabalan
added a commit
to nsivabalan/hudi
that referenced
this pull request
Jan 26, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
harsh1231
pushed a commit
to harsh1231/hudi
that referenced
this pull request
Jan 27, 2022
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Restore means rollback of N no of commits.And so, we don't publish rollback instants to timeline only during restore. but sometime back we added rollback plan to rollback requested instant and hence publishing them is unavoidable. But we missed to clean up the rollback meta files at the end of restore. this patch fixes it by cleaning up the rollback meta files from the timeline after restore is complete.
Brief change log
After finishing restore, delete all rollback instants from timeline generated as part of the restore.
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.