[HUDI-2947] Fixing checkpoint fetch in deltastreamer#4485
Merged
codope merged 2 commits intoapache:masterfrom Jan 7, 2022
Merged
[HUDI-2947] Fixing checkpoint fetch in deltastreamer#4485codope merged 2 commits intoapache:masterfrom
codope merged 2 commits intoapache:masterfrom
Conversation
codope
reviewed
Jan 6, 2022
Contributor
Author
|
@codope : addressed all comments |
Collaborator
codope
approved these changes
Jan 7, 2022
nsivabalan
added a commit
that referenced
this pull request
Jan 10, 2022
xushiyan
added
priority:critical
pratyakshsharma
changed the title
5 tasks
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
* Fixing checkpoint fetch in detlastreamer * Addressing comments
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
* Fixing checkpoint fetch in detlastreamer * Addressing comments
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
* Fixing checkpoint fetch in detlastreamer * Addressing comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Some operations in hudi may not add CHECKPOINT_KEY and CHECKPOINT_RESET_KEY like incline clustering, cleaning etc. So, deltastreamer should ignore those and go back to find the valid commit metadata from which hudi can fetch the checkpoint info.
Actual issue reported: User starts deltastreamer in continuous mode w/ inline clustering and provides a checkpoint to start with. After few commits shutsdown the job. And then restarts. Lets say incidentally last commit was replace commit (clustering). So, when deltastreamer starts, it checks for CHECKPOINT_KEY and last commit metadata which will not be present in replace commit and hence starts resuming from user provided checkpoint which should not happen.
With the fix in this patch, we go back to find the right commit metadata which has the CHECKPOINT_KEY or CHECKPOINT_RESET key and uses that to determine whether to go with checkpoint from this commit or to go with user provided one.
Brief change log
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.