[HUDI-3107]Fix HiveSyncTool drop partitions using JDBC or hivesql or hms #4453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyue19921010
changed the title
5 tasks
|
|
||
| public StringBuilder getAlterTableDropPrefix(String tableName) { | ||
| StringBuilder alterSQL = new StringBuilder("ALTER TABLE "); | ||
| alterSQL.append(HIVE_ESCAPE_CHARACTER).append(config.databaseName) |
Contributor
There was a problem hiding this comment.
I'm thinking, drop partition is not a high-frequency action, is it easier to understand using String.format? Although the performance of StringBuilder is the best.
Contributor
Author
There was a problem hiding this comment.
ahhh, keep as it is :>
| public static void createReplaceCommit(String instantTime, String partitions) | ||
| throws IOException { | ||
| HoodieReplaceCommitMetadata replaceCommitMetadata = new HoodieReplaceCommitMetadata(); | ||
| replaceCommitMetadata.setOperationType(WriteOperationType.DELETE_PARTITION); |
Contributor
There was a problem hiding this comment.
Here as a method to pass parameters?
createReplaceCommit(String instantTime, String partitions) -> createReplaceCommit(String instantTime, String partitions, WriteOperationType OperationType)
Contributor
Author
There was a problem hiding this comment.
Sure thing, Changed. Thanks a lot for your review.
Contributor
|
hi @zhangyue19921010 This pr is very good overall, thank you very much. |
| } | ||
| return String.join("/", partBuilder); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
This method is basically the same as the method in HMSDDLExecutor.java . could we abstract out a unified method？
Contributor
Author
There was a problem hiding this comment.
Okay, Changed.
Contributor
Author
|
hi @XuQianJin-Stars and @xiarixiaoyao Thanks a lot for your review. Comments are addressed. Could you please take a look? Thanks a lot. |
xiarixiaoyao
approved these changes
Dec 31, 2021
Contributor
|
@zhangyue19921010 @xiarixiaoyao : looks like there is a consistent CI failure after merging this patch https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build?definitionId=3&_a=summary |
Contributor
|
stacktrace from my local run in intellij. |
Contributor
|
I tried to fix the issue, but guess its involved. with this fix, hiveql succeeds, but hms and jdbc fails. |
Contributor
Author
|
@nsivabalan on it. |
Contributor
Author
|
The root cause of Here are the related stack trace Just raise a pr to fix the test with adding the schema info in fake replace commit file. |
Contributor
|
thanks for the quick turn around. I merged the patch. |
Contributor
Author
Thanks a lot for your review. It's my pleasure. |
5 tasks
nsivabalan
pushed a commit
that referenced
this pull request
Jan 7, 2022
…hms (#4453) * constructDropPartitions when drop partitions using jdbc * done * done * code style * code review Co-authored-by: yuezhang <[email protected]>
5 tasks
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
…hms (apache#4453) * constructDropPartitions when drop partitions using jdbc * done * done * code style * code review Co-authored-by: yuezhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix HiveSyncTool drop partitions function didn't work as expected.
Because we may build sql for jdbc or use hms api wrong.
Take jdbc as example :
Current Sql
ALTER TABLE forecast_agg DROP PARTITION (20210623/0/20210623)Correct SQL
Executing SQL ALTER TABLE yz.forecast_agg DROP IF EXISTS PARTITION (forecast_predict_date='20210623',timezone='0',date='20210623')Just add a UT named
testDropPartitionto explain this bug in detailsWithout this patch, UT will failed throws exception mentioned below