[HUDI-3104] Kafka-connect support hadoop config environments and properties#4451
Merged
yihua merged 1 commit intoapache:masterfrom Jan 9, 2022
Merged
[HUDI-3104] Kafka-connect support hadoop config environments and properties#4451yihua merged 1 commit intoapache:masterfrom
yihua merged 1 commit intoapache:masterfrom
Conversation
cdmikechen
force-pushed
the
HUDI-3104
branch
from
106dd1a to
cb4e0f0
Compare
Contributor
Author
|
@yihua Thanks for reviewing this |
codope
reviewed
Jan 6, 2022
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
@cdmikechen Few minior comments. I would prefer to avoid a new dependency if possible.
@yihua Can you also take a look?
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> |
Member
There was a problem hiding this comment.
I see this dependency is required to set env vars at test time. Is there a way to avoid this? Maybe add a wrapper class for system.getEnv calls and mock that class in test?
Contributor
Author
yihua
requested changes
Jan 6, 2022
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> |
| // Reference https://docs.confluent.io/kafka-connect-hdfs/current/configuration_options.html#hdfs | ||
| public static final ConfigProperty<String> HADOOP_CONF_DIR = ConfigProperty | ||
| .key("hadoop.conf.dir") | ||
| .defaultValue("") |
|
|
||
| public static final ConfigProperty<String> HADOOP_HOME = ConfigProperty | ||
| .key("hadoop.home") | ||
| .defaultValue("") |
| import java.nio.file.Path; | ||
| import java.util.List; | ||
|
|
||
| import static com.github.stefanbirkner.systemlambda.SystemLambda.withEnvironmentVariable; |
Contributor
There was a problem hiding this comment.
Could you use mocks to get rid of this import?
Contributor
|
@cdmikechen @yihua @codope : We are targeting this patch for 0.10.1. We have code freeze planned this monday. Would be nice to get this in by then. Wanted to send out a reminder. |
codope
reviewed
Jan 8, 2022
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
@cdmikechen Thanks for getting rid of the dependency.
Left a couple of minor comments.
nsivabalan
pushed a commit
that referenced
this pull request
Jan 10, 2022
5 tasks
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Let kafka-connect support hadoop config environments/properties
Brief change log
HADOOP_CONF_DIRandHADOOP_HOMEhadoop.conf.dirandhadoop.homeVerify this pull request
This change added tests and can be verified as follows:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.