[HUDI-3100] Add config for hive conditional sync #4440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leesf
reviewed
Dec 25, 2021
| DataSourceWriteOptions.HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE().defaultValue())); | ||
| hiveSyncConfig.supportTimestamp = Boolean.valueOf(props.getString(DataSourceWriteOptions.HIVE_SUPPORT_TIMESTAMP_TYPE().key(), | ||
| DataSourceWriteOptions.HIVE_SUPPORT_TIMESTAMP_TYPE().defaultValue())); | ||
| hiveSyncConfig.isConditionalSync = Boolean.valueOf(props.getString(DataSourceWriteOptions.HIVE_CONDITIONAL_SYNC().key(), |
Member
Author
nsivabalan
reviewed
Dec 28, 2021
Member
Author
@nsivabalan This is the changed in the patch already, right? On a separate note, do you think we should still include this in 0.10.1 given it adds a new config? So it's a matter of whether we should include a new config to fix something in the minor release. |
Contributor
|
I am ok adding it. I am seeing this as, filling in a gap we had previously. I understand, it is debatable whether to consider as bug fix or not. but I feel, we can add it. |
Contributor
|
Ocne you rebase and CI succeeds, I can land this in |
nsivabalan
approved these changes
Jan 6, 2022
xushiyan
force-pushed
the
HUDI-3100-conditional-sync-config
branch
from
b4f66ea to
d8b50f3
Compare
Collaborator
nsivabalan
pushed a commit
that referenced
this pull request
Jan 10, 2022
5 tasks
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.