Skip to content

[MINOR] remove unused method in HoodieActiveTimeline #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leesf merged 2 commits into from
Dec 20, 2021
Merged

[MINOR] remove unused method in HoodieActiveTimeline #4401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac7d0cc
remove unused method in HoodieActiveTimeline
xuzifu666 Dec 20, 2021
07916e2
Merge branch 'master' into unused_method_clean_HoodieActiveTimeline
xuzifu666 Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
import java.io.IOException;
import java.io.Serializable;
import java.text.ParseException;
import java.time.Instant;
import java.util.Arrays;
import java.util.Collections;
import java.util.Date;
Expand Down Expand Up @@ -78,13 +77,6 @@ public static Date parseDateFromInstantTime(String timestamp) throws ParseExcept
return HoodieInstantTimeGenerator.parseDateFromInstantTime(timestamp);
}

/**
* Format the java.time.Instant to a String representing the timestamp of a Hoodie Instant.
*/
public static String formatInstantTime(Instant timestamp) {
return HoodieInstantTimeGenerator.formatInstantTime(timestamp);
}

/**
* Format the Date to a String representing the timestamp of a Hoodie Instant.
*/
Expand Down Expand Up @@ -198,12 +190,6 @@ public static void deleteInstantFile(FileSystem fs, String metaPath, HoodieInsta
}
}

public void deletePendingIfExists(HoodieInstant.State state, String action, String instantStr) {
HoodieInstant instant = new HoodieInstant(state, action, instantStr);
ValidationUtils.checkArgument(!instant.isCompleted());
deleteInstantFileIfExists(instant);
}

public void deleteCompactionRequested(HoodieInstant instant) {
ValidationUtils.checkArgument(instant.isRequested());
ValidationUtils.checkArgument(Objects.equals(instant.getAction(), HoodieTimeline.COMPACTION_ACTION));
Expand Down