Skip to content

Conversation

@nsivabalan
Copy link
Contributor

What is the purpose of the pull request

  • Re-writing RFC27 in the new format (moving away from wiki) with some updates to some of the design nuances.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hujincalrin
Copy link

hujincalrin commented Dec 14, 2021

@nsivabalan
In the RFC, key format is [ColumnId] [PartitionId] [FileId]/ [ColumnId] "agg" [PartitionId],it will using hash32/hash128 to generate unique IDS,would like to know how to guarantee the uniqueness between two different columnNames/PartitionValues/FileNames after hash32/hash128? Cause once two different ColumnNames have the same ID after hash32, it may lead a wrong pruning results.

@nsivabalan
Copy link
Contributor Author

@manojpec : Can you please respond to @hujincalrin 's comment above.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@vinothchandar vinothchandar added the rfc Request for comments label Dec 15, 2021
@vinothchandar vinothchandar self-assigned this Dec 25, 2021
@nsivabalan nsivabalan changed the title [HUDI-1822][WIP] Rewriting rfc-27 for data skipping index [HUDI-1822] Rewriting rfc-27 for data skipping index Jan 25, 2022
Copy link
Contributor Author

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landing the patch for now. @manojpec plans to put up a new patch with latest updates to the RFC.

@nsivabalan nsivabalan merged commit 920f459 into apache:master Jan 25, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Jan 26, 2022
liusenhua pushed a commit to liusenhua/hudi that referenced this pull request Mar 1, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfc Request for comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants