Skip to content

[HUDI-2934] Optimize RequestHandler code style #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lsyldliu wants to merge 3 commits into from
Closed

[HUDI-2934] Optimize RequestHandler code style #4215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
688279f
[HUDI-2934] Optimize RequestHandler code style
lsyldliu Dec 4, 2021
16371f9
Improve QueryBasedDDLExecutor annotation
lsyldliu Dec 4, 2021
628a7f8
Improve SchemaDifference code style
lsyldliu Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SchemaDifference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import java.util.Map;
import java.util.StringJoiner;


/**
* Represents the schema difference between the storage schema and hive table schema.
*/
Expand Down
5 changes: 3 additions & 2 deletions hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/QueryBasedDDLExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@
import java.util.Map;

import static org.apache.hudi.hive.util.HiveSchemaUtil.HIVE_ESCAPE_CHARACTER;
/*
This class adds functionality for all query based DDLExecutors. The classes extending it only have to provide runSQL(sql) functions.

/**
* This class adds functionality for all query based DDLExecutors. The classes extending it only have to provide runSQL(sql) functions.
*/
public abstract class QueryBasedDDLExecutor implements DDLExecutor {
private static final Logger LOG = LogManager.getLogger(QueryBasedDDLExecutor.class);
Expand Down
14 changes: 7 additions & 7 deletions hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,14 +500,14 @@ public void handle(@NotNull Context context) throws Exception {

if (refreshCheck) {
long beginFinalCheck = System.currentTimeMillis();
String errMsg =
"Last known instant from client was "
+ context.queryParam(RemoteHoodieTableFileSystemView.LAST_INSTANT_TS,
HoodieTimeline.INVALID_INSTANT_TS)
+ " but server has the following timeline "
+ viewManager.getFileSystemView(context.queryParam(RemoteHoodieTableFileSystemView.BASEPATH_PARAM))
.getTimeline().getInstants().collect(Collectors.toList());
if (isLocalViewBehind(context)) {
String errMsg =
"Last known instant from client was "
+ context.queryParam(RemoteHoodieTableFileSystemView.LAST_INSTANT_TS,
HoodieTimeline.INVALID_INSTANT_TS)
+ " but server has the following timeline "
+ viewManager.getFileSystemView(context.queryParam(RemoteHoodieTableFileSystemView.BASEPATH_PARAM))
.getTimeline().getInstants().collect(Collectors.toList());
throw new BadRequestResponse(errMsg);
}
long endFinalCheck = System.currentTimeMillis();
Expand Down