[HUDI-2918] Metadata table virtual keys disabled by default #4196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojpec
changed the title
- Disabling the virtual keys by default for the metadata table
manojpec
force-pushed
the
fix/HUDI-2918-metadata-table-virtual-keys-disable
branch
from
b97cd9e to
276e56f
Compare
nsivabalan
approved these changes
Dec 2, 2021
Collaborator
Contributor
|
Taken up as part of #4194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Today metadata table doesn't honor virtual keys at the time of compaction because of HUDI-2902 This results in the metadata table with base files having records with meta fields and the delta files records with no meta fields. Better to turn off the virtual keys for the metadata table by default, and lets enable the default only after knowing all code paths are covered/tested for the metadata table.
Brief change log
Disabling the virtual keys by default for the metadata table
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.