Skip to content

[HUDI-2894][HUDI-2905] Metadata table - avoiding key lookup failures on base files over S3 #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsivabalan merged 1 commit into from
Dec 3, 2021
Merged

[HUDI-2894][HUDI-2905] Metadata table - avoiding key lookup failures on base files over S3 #4185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/HFileBootstrapIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,13 +291,13 @@ private HFile.Reader fileIdIndexReader() {

@Override
public List<String> getIndexedPartitionPaths() {
HFileScanner scanner = partitionIndexReader().getScanner(true, true);
HFileScanner scanner = partitionIndexReader().getScanner(true, false);
return getAllKeys(scanner, HFileBootstrapIndex::getPartitionFromKey);
}

@Override
public List<HoodieFileGroupId> getIndexedFileGroupIds() {
HFileScanner scanner = fileIdIndexReader().getScanner(true, true);
HFileScanner scanner = fileIdIndexReader().getScanner(true, false);
return getAllKeys(scanner, HFileBootstrapIndex::getFileGroupFromKey);
}

Expand All @@ -319,7 +319,7 @@ private <T> List<T> getAllKeys(HFileScanner scanner, Function<String, T> convert
@Override
public List<BootstrapFileMapping> getSourceFileMappingForPartition(String partition) {
try {
HFileScanner scanner = partitionIndexReader().getScanner(true, true);
HFileScanner scanner = partitionIndexReader().getScanner(true, false);
KeyValue keyValue = new KeyValue(Bytes.toBytes(getPartitionKey(partition)), new byte[0], new byte[0],
HConstants.LATEST_TIMESTAMP, KeyValue.Type.Put, new byte[0]);
if (scanner.seekTo(keyValue) == 0) {
Expand Down Expand Up @@ -352,7 +352,7 @@ public Map<HoodieFileGroupId, BootstrapFileMapping> getSourceFileMappingForFileI
List<HoodieFileGroupId> fileGroupIds = new ArrayList<>(ids);
Collections.sort(fileGroupIds);
try {
HFileScanner scanner = fileIdIndexReader().getScanner(true, true);
HFileScanner scanner = fileIdIndexReader().getScanner(true, false);
for (HoodieFileGroupId fileGroupId : fileGroupIds) {
KeyValue keyValue = new KeyValue(Bytes.toBytes(getFileGroupKey(fileGroupId)), new byte[0], new byte[0],
HConstants.LATEST_TIMESTAMP, KeyValue.Type.Put, new byte[0]);
Expand Down
2 changes: 1 addition & 1 deletion hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ public Option getRecordByKey(String key, Schema readerSchema) throws IOException

synchronized (this) {
if (keyScanner == null) {
keyScanner = reader.getScanner(false, true);
keyScanner = reader.getScanner(false, false);
}

if (keyScanner.seekTo(kv) == 0) {
Expand Down