Skip to content

[HUDI-2876] for hive/presto hudi should remove the temp file which cr… #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leesf merged 2 commits into from
Dec 6, 2021
Merged

[HUDI-2876] for hive/presto hudi should remove the temp file which cr… #4139

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f56dde
[HUDI-2876] for hive/presto hudi should remove the temp file which cr…
xiarixiaoyao Nov 27, 2021
5f72f83
[add test]
xiarixiaoyao Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...adoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeCompactedRecordReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.apache.hudi.common.model.HoodieRecordPayload;
import org.apache.hudi.common.table.log.HoodieMergedLogRecordScanner;
import org.apache.hudi.common.util.Option;
import org.apache.hudi.common.util.collection.ExternalSpillableMap;
import org.apache.hudi.hadoop.config.HoodieRealtimeConfig;
import org.apache.hudi.hadoop.utils.HoodieInputFormatUtils;
import org.apache.hudi.hadoop.utils.HoodieRealtimeRecordReaderUtils;
Expand Down Expand Up @@ -188,6 +189,7 @@ public long getPos() throws IOException {

@Override
public void close() throws IOException {
((ExternalSpillableMap) deltaRecordMap).close();

@leesf leesf Dec 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible to add an ut for this?

@xiarixiaoyao xiarixiaoyao Dec 2, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UT added.
now we have no way to get the path of DiskMap in RealtimeCompactedRecordReader.
so in the test we search the TMP file and check whether it has been deleted

parquetReader.close();
}

Expand Down