[HUDI-2862] Table upgrade and metadata table bootstrap under the table lock (replaces #4124) #4134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… table lock - Today table upgrade need is detected by the first write client after upgrade and if there is write concurrency mode configured it grabs the transaction lock to protect the table upgrade from other concurrent writers. However, the follow on metadata table creation and the initial bootstrapping also needs similar global protection to avoid race in inflight commits and the metadata table bootstrapping proces. Made the table upgrade and the follow-on metadata table creation and there by the initial bootstrapping process under the table level lock to avoid potential race with concurrent writers and other async table services.
manojpec
force-pushed
the
fix/HUDI-2862-metadata-table-bootstrap-under-table-lock-2
branch
from
84a405a to
2a59c48
Compare
5 tasks
manojpec
changed the title
Contributor
|
@hudi-bot azure run |
1 similar comment
Contributor
|
@hudi-bot azure run |
Collaborator
Contributor
Author
|
This change is now pulled into #4114. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
and if there is write concurrency mode configured it grabs the transaction
lock to protect the table upgrade from other concurrent writers. However, the
follow on metadata table creation and the initial bootstrapping also needs
similar global protection to avoid race in inflight commits and the metadata
table bootstrapping proces. Made the table upgrade and the follow-on metadata
table creation and there by the initial bootstrapping process under the
table level lock to avoid potential race with concurrent writers and other
async table services.
NOTE: This is a DUP of #4124, to help avoid rebase/merge conflicts
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.