Skip to content

[HUDI-1290] fixing mysql Debezium source #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsivabalan merged 1 commit into from
Nov 25, 2021
Merged

[HUDI-1290] fixing mysql Debezium source #4119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...ilities/src/main/java/org/apache/hudi/utilities/sources/debezium/MysqlDebeziumSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ protected Dataset<Row> processDataset(Dataset<Row> rowDataset) {
String.format("%s as %s", DebeziumConstants.INCOMING_TS_MS_FIELD, DebeziumConstants.UPSTREAM_PROCESSING_TS_COL_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_NAME_FIELD, DebeziumConstants.FLATTENED_SHARD_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_TS_MS_FIELD, DebeziumConstants.FLATTENED_TS_COL_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_TXID_FIELD, DebeziumConstants.FLATTENED_TX_ID_COL_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_FILE_FIELD, DebeziumConstants.FLATTENED_FILE_COL_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_POS_FIELD, DebeziumConstants.FLATTENED_POS_COL_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_ROW_FIELD, DebeziumConstants.FLATTENED_ROW_COL_NAME),
Expand All @@ -82,7 +81,6 @@ protected Dataset<Row> processDataset(Dataset<Row> rowDataset) {
String.format("%s as %s", DebeziumConstants.INCOMING_TS_MS_FIELD, DebeziumConstants.UPSTREAM_PROCESSING_TS_COL_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_NAME_FIELD, DebeziumConstants.FLATTENED_SHARD_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_TS_MS_FIELD, DebeziumConstants.FLATTENED_TS_COL_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_TXID_FIELD, DebeziumConstants.FLATTENED_TX_ID_COL_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_FILE_FIELD, DebeziumConstants.FLATTENED_FILE_COL_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_POS_FIELD, DebeziumConstants.FLATTENED_POS_COL_NAME),
String.format("%s as %s", DebeziumConstants.INCOMING_SOURCE_ROW_FIELD, DebeziumConstants.FLATTENED_ROW_COL_NAME),
Expand Down
4 changes: 0 additions & 4 deletions ...ies/src/test/java/org/apache/hudi/utilities/sources/debezium/TestMysqlDebeziumSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public class TestMysqlDebeziumSource extends TestAbstractDebeziumSource {
private static final String TEST_DB = "ghschema";
private static final String TEST_TABLE = "gharchive";
private static final long TEST_TS_MS = 12345L;
private static final long TEST_TXID = 543L;
private static final String TEST_FILE = "mysql-bin.00007";
private static final long TEST_POS = 98765L;
private static final String EXPECTED_TEST_SEQ = "00007.98765";
Expand Down Expand Up @@ -79,7 +78,6 @@ protected GenericRecord generateMetaFields(GenericRecord rec) {
sourceRecord.put("db", TEST_DB);
sourceRecord.put("table", TEST_TABLE);
sourceRecord.put("ts_ms", TEST_TS_MS);
sourceRecord.put("txId", TEST_TXID);
sourceRecord.put("file", TEST_FILE);
sourceRecord.put("pos", TEST_POS);
rec.put(DebeziumConstants.INCOMING_SOURCE_FIELD, sourceRecord);
Expand All @@ -92,8 +90,6 @@ protected void validateMetaFields(Dataset<Row> records) {
.allMatch(r -> r.getString(0).equals(getIndexName())));
assertTrue(records.select(DebeziumConstants.FLATTENED_TS_COL_NAME).collectAsList().stream()
.allMatch(r -> r.getLong(0) == TEST_TS_MS));
assertTrue(records.select(DebeziumConstants.FLATTENED_TX_ID_COL_NAME).collectAsList().stream()
.allMatch(r -> r.getLong(0) == TEST_TXID));
assertTrue(records.select(DebeziumConstants.ADDED_SEQ_COL_NAME).collectAsList().stream()
.allMatch(r -> r.getString(0).equals(EXPECTED_TEST_SEQ)));
}
Expand Down