[HUDI-2757] [Stacked over 4175] Implement Sync for AWS Glue Catalog #4080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmahindra123
changed the title
rmahindra123
changed the title
xushiyan
reviewed
Nov 24, 2021
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/AbstractHiveSyncHoodieClient.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/AbstractHiveSyncHoodieClient.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/GlueSyncTool.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/GlueSyncTool.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HoodieGlueClient.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HoodieGlueClient.java
Outdated
Show resolved
Hide resolved
...ync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/AbstractSyncHoodieClient.java
Outdated
Show resolved
Hide resolved
xushiyan
reviewed
Nov 24, 2021
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HoodieGlueClient.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HoodieGlueClient.java
Outdated
Show resolved
Hide resolved
rmahindra123
force-pushed
the
rm_add_glue_sync
branch
from
9b0ca82 to
6df7ea7
Compare
xushiyan
approved these changes
Nov 26, 2021
Member
xushiyan
left a comment
xushiyan
left a comment
There was a problem hiding this comment.
lgtm. just some naming suggestions.
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/AwsGDCSyncTool.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/AwsGDCSyncTool.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/GlueDataCatalogClient.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/GlueDataCatalogClient.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/GlueDataCatalogClient.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/GlueDataCatalogClient.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/AwsGDCSyncTool.java
Outdated
Show resolved
Hide resolved
rmahindra123
force-pushed
the
rm_add_glue_sync
branch
from
6df7ea7 to
c5d8f1f
Compare
Member
vinothchandar
left a comment
vinothchandar
left a comment
There was a problem hiding this comment.
I am not sure if we should land this one, this late. There are some moving around of classes here, that probably needs a closer look
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
Outdated
Show resolved
Hide resolved
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/replication/GlobalHiveSyncTool.java
Outdated
Show resolved
Hide resolved
...a-connect/src/main/java/org/apache/hudi/connect/writers/KafkaConnectTransactionServices.java
Outdated
Show resolved
Hide resolved
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/AWSGlueCatalogClient.java
Outdated
Show resolved
Hide resolved
rmahindra123
force-pushed
the
rm_add_glue_sync
branch
from
1483089 to
cd5069d
Compare
rmahindra123
changed the title
added 12 commits
December 6, 2021 13:30
added 13 commits
December 6, 2021 13:30
rmahindra123
force-pushed
the
rm_add_glue_sync
branch
from
cd5069d to
eb8da37
Compare
rmahindra123
changed the title
rmahindra123
changed the title
Collaborator
|
Hey Guys, do you think it will be merged any time soon? Thank you |
|
Hi, Any update on this PR? Just wondering if we are still on track to release this feature with Hudi |
|
Hey Guys, Any chance to merge this soon? |
Member
@rubenssoto @sshah90 Taking over this. Porting over to #5076 |
xushiyan
added
priority:blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This feature will start by being experimental.
Extend the hive sync tool to enable AWS Glue meta sync.
Deltastreamer can also be configured to sync with the AWS Glue metastore asynchronously.
Brief change log