Skip to content

[MINOR] Fixed checkstyle config to be based off Maven root-dir #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsivabalan merged 1 commit into from
Nov 17, 2021
Merged

[MINOR] Fixed checkstyle config to be based off Maven root-dir #4009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Prerequisites for building Apache Hudi:
* Unix-like system (like Linux, Mac OS X)
* Java 8 (Java 9 or 10 may work)
* Git
* Maven
* Maven (>=3.3.1)

```
# Checkout code and build
Expand Down
2 changes: 2 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,8 @@
<sourceDirectories>
<sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
</sourceDirectories>
<!-- NOTE: This property is only available in Maven >= 3.3.1 -->
<propertyExpansion>basedir=${maven.multiModuleProjectDirectory}</propertyExpansion>
<excludes>**\/generated-sources\/</excludes>
</configuration>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion style/checkstyle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@
<module name="SimplifyBooleanExpression"/>

<module name="ImportControl">
<property name="file" value="style/import-control.xml"/>
<property name="file" value="${basedir}/style/import-control.xml"/>
<property name="path" value="^.*[\\/]hudi-client[\\/]hudi-client-common[\\/]src[\\/].*$"/>
</module>

Expand Down