Skip to content

Conversation

@yuzhaojing
Copy link
Contributor

…h the latest schema

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to create the write client again, just update the schema of the write config, and in which case do we need the schema evolution, schema evolution is not supported now ~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will update this and waiting for schema evolution supported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess writeConfig.setSchema should work, so no need to rebuild it ~

@nsivabalan
Copy link
Contributor

@danny0405 : can you loop in someone to follow up on reviews. guess we dropped the ball on this.

@hudi-bot
Copy link
Collaborator

hudi-bot commented Mar 1, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit 3b2da9f into apache:master Mar 2, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
…h the latest schema (apache#4000)

Co-authored-by: yuzhaojing <yuzhaojing@bytedance.com>
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 12, 2022
…h the latest schema (apache#4000)

Co-authored-by: yuzhaojing <yuzhaojing@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants