[HUDI-2767] Enabling timeline server based marker as default #3967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@vinothchandar : wrt structured streaming and timeline server being closed ahead, this is what I see. After the end of first micro batch, the write client is closed and hence triggers closure of timeline service. but subsequent micro batches do succeed though. I added some logs for testStructuredStreaming (using direct markers) Test was using direct marker types for the purpose of collecting logs. if I switch to timeline server based(intent of this patch), test will fail since the 2nd batch marker creations fail. |
codope
approved these changes
Nov 17, 2021
nsivabalan
force-pushed
the
enableRollbackUsingMarkers
branch
from
0bb1d33 to
09f87e9
Compare
nsivabalan
force-pushed
the
enableRollbackUsingMarkers
branch
from
b897418 to
0ab4fdb
Compare
Contributor
Author
|
@hudi-bot azure run |
Contributor
Author
|
@vinothchandar : I am thinking, for users who explicitly disable timeline server, should we fallback to using direct style markers? |
Collaborator
Contributor
Author
|
@hudi-bot azure run |
nsivabalan
changed the title
Contributor
@nsivabalan We have jobs that disable timeline server in production environment, for backward compatibility, we should fallback to using direct style markers. |
manojpec
approved these changes
Nov 22, 2021
| .withEngineType(EngineType.JAVA) | ||
| .withPath(basePath) | ||
| .withSchema(schema.toString()) | ||
| .withMarkersType(MarkerType.DIRECT.name()) |
Contributor
There was a problem hiding this comment.
Any plan/ticket to convert all these tests to timeline based markers? Or by design these still have to be direct type?
Contributor
|
I'm putting up another PR to flip the default and fix things: #4112. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
we might have to re-think enabling timeline server based marker as default.
incase of structured streaming, once the source stream completes, it shuts down the timeline server. and so some writes to hudi fails while creating the markers (timeline server based). I need to understand this flow better, whether we need to fix the structured streaming or its an inherent constraint.
#3950 is a pre-requisite to land this PR. If not, I might have to do duplicate test fixes. So, will first land #3950 and then will attempt at fixing the remaining test failures. I did go through once pass already. Except for structured streaming, I don't see any other major issues.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.