Skip to content

Conversation

@codope
Copy link
Member

@codope codope commented Nov 10, 2021

Add implementation details

Update table with new rfc

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@codope
Copy link
Member Author

codope commented Nov 10, 2021

@caneGuy
Copy link

caneGuy commented Nov 10, 2021

greate @codope thanks for this. i will take a look later this week!

@vinothchandar vinothchandar added the rfc Request for comments label Nov 21, 2021
@codope codope changed the title [HUDI-2688][RFC-37] A new Hudi connector for Trino [HUDI-2688][RFC-40] A new Hudi connector for Trino Nov 24, 2021
@vinothchandar
Copy link
Member

this high level makes sense to me. @codope should we keep this open for further comments or do you plan to add more specific details around how we integrate with hive metastore, what we give up against the hive-connector and any other implementation constraints.

@codope codope force-pushed the rfc-37 branch 3 times, most recently from c57c90d to ecb89c3 Compare December 23, 2021 11:38
@vinothchandar vinothchandar self-assigned this Dec 25, 2021
Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions.

Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. You can land the RFC once they are addressed!

Add implementation details

Update table with new rfc

Correct rfc number

Add more details related Hudi and split management

Mention metadata-based listing

Link the rfc in readme

Changing status of the RFC

Minor edits to the RFC

Update connector design

Update class hierarchy diagram

Update high-def diagram

Fix nit

Address review comments
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope codope merged commit 2b52a56 into apache:master Jan 28, 2022
liusenhua pushed a commit to liusenhua/hudi that referenced this pull request Mar 1, 2022
Add implementation details of a new hudi-trino connector
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
Add implementation details of a new hudi-trino connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfc Request for comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants