-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-2102] Support hilbert curve for hudi #3952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6f77921
[HUDI-2102][WIP] support hilbert curve for hudi.
xiarixiaoyao 0668663
add benchmark exmaple for space-curve optimize
xiarixiaoyao 36f3dc6
fix comments
xiarixiaoyao 295f26f
fix test bug
xiarixiaoyao cb2fc3e
Address review comments
yihua 0d034fb
Fix rebase issues
yihua 411029a
Fix build regarding z-ordering changes
yihua 688052e
Add one more test for padding
yihua da9b8fc
Whitelist hilbert curve dependency in the bundles
yihua 4d17773
Fix NoClassDefFoundError for com/github/davidmoten/guavamini/Precondi…
yihua 503ebc7
Fixes from xiarixiaoyao
yihua 18d2357
Update HilbertCurveUtils.java
xiarixiaoyao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/optimize/HilbertCurveUtils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.hudi.optimize; | ||
|
|
||
| import org.davidmoten.hilbert.HilbertCurve; | ||
|
|
||
| import java.math.BigInteger; | ||
|
|
||
| /** | ||
| * Utils for Hilbert Curve. | ||
| */ | ||
| public class HilbertCurveUtils { | ||
| public static byte[] indexBytes(HilbertCurve hilbertCurve, long[] points, int paddingNum) { | ||
| BigInteger index = hilbertCurve.index(points); | ||
| return paddingToNByte(index.toByteArray(), paddingNum); | ||
| } | ||
|
|
||
| public static byte[] paddingToNByte(byte[] a, int paddingNum) { | ||
| if (a.length == paddingNum) { | ||
| return a; | ||
| } | ||
| if (a.length > paddingNum) { | ||
| byte[] result = new byte[paddingNum]; | ||
| System.arraycopy(a, 0, result, 0, paddingNum); | ||
| return result; | ||
| } | ||
| int paddingSize = paddingNum - a.length; | ||
| byte[] result = new byte[paddingNum]; | ||
| for (int i = 0; i < paddingSize; i++) { | ||
| result[i] = 0; | ||
| } | ||
| System.arraycopy(a, 0, result, paddingSize, a.length); | ||
| return result; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
...ient/hudi-client-common/src/test/java/org/apache/hudi/optimize/TestHilbertCurveUtils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.hudi.optimize; | ||
|
|
||
| import org.davidmoten.hilbert.HilbertCurve; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| public class TestHilbertCurveUtils { | ||
|
|
||
| private static final HilbertCurve INSTANCE = HilbertCurve.bits(5).dimensions(2); | ||
|
|
||
| @Test | ||
| public void testIndex() { | ||
| long[] t = {1, 2}; | ||
| assertEquals(13, INSTANCE.index(t).intValue()); | ||
| long[] t1 = {0, 16}; | ||
| assertEquals(256, INSTANCE.index(t1).intValue()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's default
valueOfin every Enum. What do we need this method for?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SpaceCurveOptimizeHelper.createOptimizedDataFrameByMapValue will use this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't it use default
valueOf?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry,
i want use "z-order", "hilbert" as the parmeter not "ZORDER". "HILBERT"
and if we want to call this method in scala. valueOf will not work.