[HUDI-1500] Support replace commit in DeltaSync with commit metadata preserved #3802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nsivabalan
requested changes
Oct 19, 2021
Contributor
nsivabalan
left a comment
nsivabalan
left a comment
There was a problem hiding this comment.
Is it possible to write a test for deltastreamer to test the actual fix.
…preserved Test async clustering in deltastreamer with and without metadata preserved
Member
Author
I have modified the existing async clustering tests to run for both, with and without commit metadata preserved. Since we're only removing the filter, this should cover the scenario that the removal works with replace commits in continuous deltastreamer mode. |
nsivabalan
reviewed
Oct 22, 2021
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java
Outdated
Show resolved
Hide resolved
nsivabalan
approved these changes
Oct 29, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR fixes HUDI-1500 for deltastreamer. For Spark datasource, it was fixed by #3139
Brief change log
Verify this pull request
This pull request is already covered by existing tests.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.