Skip to content

Conversation

@nsivabalan
Copy link
Contributor

@nsivabalan nsivabalan commented Oct 11, 2021

Check just the 2nd commit. 1st commit is #3762

  • Adding parquet data block with inline read support.
  • Added a config hoodie.table.log.block.type to determine the log block type. If not set, we will fallback to determining log block type based on base file format. if set, we will use the config value.
  • Added some minimal tests to ensure adding a parquet data block and reading it using AbstractLogRecordScanner works fine.

Pending items:

  • where to store the configs for new parquet data block. we need index configs, and parquet write configs too. Don't think we can reuse existing ones its purpose is different.
  • Once have consensus, will have to fix the configs for the same.
  • Add more end to end tests to test parquet data blocks.

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@nsivabalan nsivabalan added the status:in-progress Work in progress label Oct 11, 2021
@nsivabalan
Copy link
Contributor Author

@rmahindra123 : can you please review this.

@vinothchandar vinothchandar self-assigned this Oct 15, 2021
@nsivabalan nsivabalan force-pushed the inlineReadParquetDataBlock branch from 761ed1b to eaa4ed2 Compare October 21, 2021 13:56
@nsivabalan nsivabalan changed the title [WIP] Adding parquet data block with inline read support [HUDI-431] [WIP] Adding parquet data block with inline read support Oct 21, 2021
@nsivabalan nsivabalan force-pushed the inlineReadParquetDataBlock branch from eaa4ed2 to 8eeaaf0 Compare October 21, 2021 14:38
@nsivabalan nsivabalan added the priority:blocker Production down; release blocker label Nov 3, 2021
@hudi-bot
Copy link
Collaborator

hudi-bot commented Nov 5, 2021

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan
Copy link
Contributor Author

closing in favor of #3930

@nsivabalan nsivabalan closed this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker status:in-progress Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants