Skip to content

[HUDI-2409] Using HBase shaded jars in Hudi presto bundle #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codope merged 13 commits into from
Nov 23, 2021
Merged

[HUDI-2409] Using HBase shaded jars in Hudi presto bundle #3623

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
71b58be
using hbase-shaded-jars-in-hudi-presto-hundle
Sep 8, 2021
a34260e
Merge branch 'master' into hudi-integrate-with-presto-using-bundle
Sep 16, 2021
72fc50e
test
Sep 22, 2021
5e03c2f
add hudi-common-bundle
Sep 24, 2021
7857724
code review
Oct 8, 2021
44b2556
code review
Oct 8, 2021
1189b03
Merge branch 'master' into hudi-integrate-with-presto-using-bundle
Oct 8, 2021
b009519
code review
Oct 8, 2021
20c9cfd
code review
Oct 8, 2021
8a3b119
merge from master
Nov 12, 2021
ce5b4e2
merge from master
Nov 15, 2021
ede8932
test
Nov 15, 2021
7781df5
test
Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions packaging/hudi-presto-bundle/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,65 @@
<groupId>org.apache.hudi</groupId>
<artifactId>hudi-common</artifactId>
<version>${project.version}</version>
<exclusions>
<exclusion>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-server</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-client</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.hudi</groupId>
<artifactId>hudi-hadoop-mr-bundle</artifactId>
<version>${project.version}</version>
<exclusions>
<exclusion>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-server</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-client</artifactId>
</exclusion>
</exclusions>
</dependency>

<!-- https://mvnrepository.com/artifact/org.apache.hbase/hbase-shaded-client -->
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-shaded-client</artifactId>
<version>${hbase.version}</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-shaded-server</artifactId>
Copy link
Contributor

@yanghua yanghua Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also introduce this dependency in hudi-common?

Copy link
Member

@codope codope Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@zhangyue19921010 If we add to hudi-common then it should be sufficient. hudi-common is a dependency in hudi-presto-bundle. It also makes sense from the perpective of integrating with Presto. That way we will only need to add hudi-common dependency in presto-hive module (which should be lighter than adding hudi-presto-bundle).

<version>${hbase.version}</version>
<!-- Unfortunately, HFile is packaged ONLY under hbase-server -->
<scope>compile</scope>
<exclusions>
<exclusion>
<groupId>javax.servlet</groupId>
<artifactId>*</artifactId>
</exclusion>
<exclusion>
<groupId>org.codehaus.jackson</groupId>
<artifactId>*</artifactId>
</exclusion>
<exclusion>
<groupId>org.mortbay.jetty</groupId>
<artifactId>*</artifactId>
</exclusion>
<exclusion>
<groupId>tomcat</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>

<!-- Parquet -->
Expand Down