Skip to content

Conversation

@umehrot2
Copy link
Contributor

@umehrot2 umehrot2 commented Aug 3, 2021

Tips

What is the purpose of the pull request

Set better default to improve out of the box performance for Hudi. This so far does the following:

  • Enable metadata table (for writers)
  • Enable bulk insert using row writer
  • Disable optimistic consistency guard
  • Enable rollback using markers
  • Set version 1 as the default timeline layout version

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link
Collaborator

hudi-bot commented Aug 3, 2021

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run travis re-run the last Travis build
  • @hudi-bot run azure re-run the last Azure build

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, there are many optimization options in hoodie and most of them are false, like the metadata table, i'm confused why.

@yanghua
Copy link
Contributor

yanghua commented Aug 3, 2021

+1, there are many optimization options in hoodie and most of them are false, like the metadata table, i'm confused why.

Maybe, some features are marked the early beta label. They are experimental, will turn on as default behavior in the later version.

@umehrot2 umehrot2 added the priority:blocker Production down; release blocker label Aug 3, 2021
@umehrot2
Copy link
Contributor Author

umehrot2 commented Aug 5, 2021

Put out a separate PR to enable metadata, as enabling some of these might be more involved #3411 . Keeping this PR open, and will use this to enable the non-trivial defaults.

@vinothchandar vinothchandar self-assigned this Aug 5, 2021
@danny0405
Copy link
Contributor

Is this PR plan to be included in 0.9 release ?

@vinothchandar
Copy link
Member

@nsivabalan once your PR passes, we could close this in favor of that

@umehrot2
Copy link
Contributor Author

Is this PR plan to be included in 0.9 release ?

@danny0405 If you are thinking specifically about metadata table, we will not be enabling it by default in Hudi 0.9.0. At this point, we are still seeing several test failures when enabling metadata #3411, and some of them are actual bugs. So, we have taken a call to stabilize this after Hudi 0.9.0, potentially in another minor release 0.9.1.

For other defaults, I think @nsivabalan has separate PRs put out to enable some of them. We will try to land whatever seem stable by tomorrow. cc @vinothchandar

@nsivabalan nsivabalan removed the priority:blocker Production down; release blocker label Aug 13, 2021
@nsivabalan
Copy link
Contributor

Removed from releasea-blocker in favor of #3452

@nsivabalan
Copy link
Contributor

@umehrot2 : we have already landed 6 to 8 defaults in last release. So, closing this out. If you have more, do put up a new patch.

@nsivabalan nsivabalan closed this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants