-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-2151] Enable defaults for out of box performance #3383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
danny0405
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, there are many optimization options in hoodie and most of them are false, like the metadata table, i'm confused why.
Maybe, some features are marked the early beta label. They are experimental, will turn on as default behavior in the later version. |
|
Put out a separate PR to enable metadata, as enabling some of these might be more involved #3411 . Keeping this PR open, and will use this to enable the non-trivial defaults. |
|
Is this PR plan to be included in 0.9 release ? |
|
@nsivabalan once your PR passes, we could close this in favor of that |
@danny0405 If you are thinking specifically about metadata table, we will not be enabling it by default in Hudi 0.9.0. At this point, we are still seeing several test failures when enabling metadata #3411, and some of them are actual bugs. So, we have taken a call to stabilize this after Hudi 0.9.0, potentially in another minor release 0.9.1. For other defaults, I think @nsivabalan has separate PRs put out to enable some of them. We will try to land whatever seem stable by tomorrow. cc @vinothchandar |
|
Removed from releasea-blocker in favor of #3452 |
|
@umehrot2 : we have already landed 6 to 8 defaults in last release. So, closing this out. If you have more, do put up a new patch. |
Tips
What is the purpose of the pull request
Set better default to improve out of the box performance for Hudi. This so far does the following:
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.