[HUDI-1518] Remove the logic that delete replaced file when archive #3310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 20, 2021 16:48
Codecov Report
@@ Coverage Diff @@
## master #3310 +/- ##
============================================
- Coverage 47.83% 47.78% -0.05%
- Complexity 5565 5598 +33
============================================
Files 936 938 +2
Lines 41663 41815 +152
Branches 4197 4211 +14
============================================
+ Hits 19929 19983 +54
- Misses 19960 20045 +85
- Partials 1774 1787 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
@satishkotha do you mind taking a second look at this? Seems ok to do. |
satishkotha
approved these changes
Aug 11, 2021
Member
satishkotha
left a comment
satishkotha
left a comment
There was a problem hiding this comment.
LGTM. Couple minor comments to see if we can remove more dead code.
|
|
||
| TableFileSystemView fileSystemView = this.table.getFileSystemView(); | ||
| List<String> replacedPartitions = getReplacedPartitions(instant); | ||
| return ReplaceArchivalHelper.deleteReplacedFileGroups(context, metaClient, fileSystemView, instant, replacedPartitions); |
Member
There was a problem hiding this comment.
Do we need ReplaceArchivalHelper class?
|
|
||
| // when using insert_overwrite or insert_overwrite_table | ||
| // first commit may without replaceFileIds | ||
| createReplaceMetadataWithoutReplaceFileId("000"); |
Member
There was a problem hiding this comment.
Could we also remove these helper methods?
Member
|
@hudi-bot run azure LGTM. i'll merge after azure builds pass |
Contributor
Author
|
Hi @satishkotha Thanks a lot for your review and merge! |
liujinhui1994
pushed a commit
to liujinhui1994/hudi
that referenced
this pull request
Aug 12, 2021
…pache#3310) * remove delete replaced file when archive * done * remove unsed import * remove delete replaced files when archive realted UT * code reviewed Co-authored-by: yuezhang <[email protected]>
5 tasks
leesf
pushed a commit
to leesf/hudi
that referenced
this pull request
Nov 24, 2022
…pache#3310) * remove delete replaced file when archive * done * remove unsed import * remove delete replaced files when archive realted UT * code reviewed Co-authored-by: yuezhang <[email protected]>
leesf
pushed a commit
to leesf/hudi
that referenced
this pull request
Nov 24, 2022
…rchive (apache#3310)" This reverts commit 2c2cab1e32e42cd59b5edee9b37dfd1c5946a9de.
leesf
pushed a commit
to leesf/hudi
that referenced
this pull request
Nov 24, 2022
…pache#3310) * remove delete replaced file when archive * done * remove unsed import * remove delete replaced files when archive realted UT * code reviewed Co-authored-by: yuezhang <[email protected]>
leesf
pushed a commit
to leesf/hudi
that referenced
this pull request
Nov 24, 2022
…rchive (apache#3310)" This reverts commit 2c2cab1e32e42cd59b5edee9b37dfd1c5946a9de.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Since #2422 Cleaner now takes care of removing replaced file groups. This call to deleteReplacedFileGroups can be removed.
Also it's a little confused that archive can delete data file even users set auto.clean false.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.