Skip to content

[HUDI-2136] Fix conflict when flink-sql-connector-hive and hudi-flink-bundle are both in flink lib #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanghua merged 1 commit into from
Jul 9, 2021
Merged

[HUDI-2136] Fix conflict when flink-sql-connector-hive and hudi-flink-bundle are both in flink lib #3227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packaging/hudi-flink-bundle/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@
<include>org.datanucleus:datanucleus-api-jdo</include>
<include>org.apache.thrift:libfb303</include>
<include>org.apache.orc:orc-core</include>
<include>org.apache.flink:flink-sql-connector-hive-2.3.6_${scala.binary.version}</include>

<include>org.apache.hbase:hbase-common</include>
<include>commons-codec:commons-codec</include>
Expand Down Expand Up @@ -633,5 +634,15 @@
</dependency>
</dependencies>
</profile>
<profile>
<id>include-flink-sql-connector-hive</id>
Copy link
Contributor

@yanghua yanghua Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we exclude the conflict dependencies instead of introducing a new profile?

Copy link
Contributor Author

@swuferhong swuferhong Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we exclude the conflict dependencies instead of introducing a new profile?

We try to exclude the conflict before, but too many conflicts dependencies between flink-sql-connector-hive and our hudi-flink-bundle, we failed to exclude all conflicts.

Copy link
Contributor

@yanghua yanghua Jul 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK~

<dependencies>
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-sql-connector-hive-2.3.6_${scala.binary.version}</artifactId>
<version>${flink.version}</version>
</dependency>
</dependencies>
</profile>
</profiles>
</project>