-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-2034] Support explicit partition compaction strategy for flink … #3100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3100 +/- ##
============================================
- Coverage 46.26% 46.25% -0.02%
Complexity 5362 5362
============================================
Files 920 921 +1
Lines 39824 39850 +26
Branches 4289 4293 +4
============================================
+ Hits 18425 18431 +6
- Misses 19518 19535 +17
- Partials 1881 1884 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compaction strategy with explicit partition, it is based on the {@link LogFileSizeBasedCompactionStrategy}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicit partition to compact with, by default, compact all the partitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicit partition to compact with, by default, compact all the partitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/**
* Set the compaction strategy.
* /58e32ac to
c3215f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use FlinkOptions.COMPACTION_PARTITION.key()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify the logic to be synced with HoodieFlinkCompactor.
9d7f1d1 to
8a9fed1
Compare
|
@swuferhong can we resume the work pls? or are we good to close this? cc @danny0405 |
|
Close it because the author is not active. |
…batch compaction
Tips
What is the purpose of the pull request
This PR is to support explicit partition compaction strategy for flink batch compaction. As PR #3046 support flink batch compaction, this PR can specify partition to compaction based on flink hudi batch compaction.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.