[HUDI-1441] Fixing HoodieAvroUtils.rewriteRecord for nested record schema evolution #2982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #2982 +/- ##
=============================================
+ Coverage 54.80% 70.88% +16.07%
+ Complexity 3826 386 -3440
=============================================
Files 485 54 -431
Lines 23424 2016 -21408
Branches 2495 241 -2254
=============================================
- Hits 12838 1429 -11409
+ Misses 9431 454 -8977
+ Partials 1155 133 -1022
Flags with carried forward coverage won't be shown. Click here to find out more. |
nsivabalan
force-pushed
the
hoodieAvroUtils_rewriteToEvolvedSchema
branch
from
272b5a7 to
92ca2e9
Compare
nsivabalan
added
status:in-progress
Member
|
cc @codope could you chime in here? |
Collaborator
Contributor
Author
|
@codope : can you review this patch please. |
codope
reviewed
Jan 28, 2022
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
Overall looks good. Left a few minor comments.
| } | ||
|
|
||
| @Test | ||
| public void testRewriteToEvolvedNestedRecord() throws Exception { |
Member
There was a problem hiding this comment.
remove Exception here and below?
| } | ||
| return datum; | ||
| case UNION: | ||
| Integer idx = (newSchema.getTypes().get(0).getType() == Schema.Type.NULL) ? 1 : 0; |
Member
There was a problem hiding this comment.
instead of wrapper class, can we use the primitive type int here?
| assertEquals("val2", newRecord.get("pii_col")); | ||
| assertEquals(null, ((GenericRecord)newRecord.get("color_rec")).get("color_name")); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
Member
There was a problem hiding this comment.
let's remove printStackTrace here and below?
yihua
added
area:schema
Contributor
|
Is this still relevant? @jonvex could you check this too? |
Contributor
|
The revamp PR is #11893. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #2309
What is the purpose of the pull request
If schema contains nested records, then HoodieAvroUtils rewrite() function copies the record fields as-is, from the oldrecord to the newRecord. If fields of the nested record have evolved, it would result in SchemaCompatibilityException or ArrayIndexOutOfBoundsException.
Brief change log
Modify HoodieAvroUtils rewrite() to rewrite the evolved fields, with new/evolved fields initialized to null.
Verify this pull request
This pull request is already covered by existing tests, such as TestHoodieAvroUtils.
Added testRewriteToEvolvedNestedRecord() and testRewriteToShorterRecord()
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.