Skip to content

[HUDI-1637] Avoid to rename for bucket update when there is only one … #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanghua merged 1 commit into from
Feb 25, 2021
Merged

[HUDI-1637] Avoid to rename for bucket update when there is only one … #2599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/FlinkMergeHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ public FlinkMergeHandle(HoodieWriteConfig config, String instantTime, HoodieTabl
* Use the fileId + "-" + rollNumber as the new fileId of a mini-batch write.
*/
protected String generatesDataFileName() {
return FSUtils.makeDataFileName(instantTime, writeToken, fileId + "-" + rollNumber, hoodieTable.getBaseFileExtension());
final String fileID = this.needBootStrap ? fileId : fileId + "-" + rollNumber;
return FSUtils.makeDataFileName(instantTime, writeToken, fileID, hoodieTable.getBaseFileExtension());
}

public boolean isNeedBootStrap() {
Expand Down Expand Up @@ -178,6 +179,12 @@ public void rollOver(Iterator<HoodieRecord<T>> newRecordsItr) {
}

public void finishWrite() {
// The file visibility should be kept by the configured ConsistencyGuard instance.
if (rolloverPaths.size() == 1) {
// only one flush action, no need to roll over
return;
}

for (int i = 0; i < rolloverPaths.size() - 1; i++) {
Path path = rolloverPaths.get(i);
try {
Expand Down