Skip to content

[HUDI-1606]align BaseJavaCommitActionExecuto#execute method with BaseSparkCommitActionExecutor #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caidezhi wants to merge 3 commits into from
Closed

[HUDI-1606]align BaseJavaCommitActionExecuto#execute method with BaseSparkCommitActionExecutor #2560

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc9fdb0
[HUDI-1606]fix HoodieJavaWriteClientExample
Feb 9, 2021
a08b2db
[HUDI-1606]align BaseJavaCommitActionExecuto#execute method with Base…
Feb 10, 2021
835aed0
Merge branch 'master' of https://github.com/apache/hudi
caidezhi Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...lient/src/main/java/org/apache/hudi/table/action/commit/BaseJavaCommitActionExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public HoodieWriteMetadata<List<WriteStatus>> execute(List<HoodieRecord<T>> inpu
handleInsertPartition(instantTime, partition, records.iterator(), partitioner).forEachRemaining(writeStatuses::addAll);
}
});
updateIndex(writeStatuses, result);
updateIndexAndCommitIfNeeded(writeStatuses, result);
return result;
}

Expand All @@ -132,6 +132,11 @@ protected void updateIndex(List<WriteStatus> writeStatuses, HoodieWriteMetadata<
result.setWriteStatuses(statuses);
}

protected void updateIndexAndCommitIfNeeded(List<WriteStatus> writeStatuses, HoodieWriteMetadata<List<WriteStatus>> result) {
Copy link
Contributor

@leesf leesf Feb 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caidezhi Sorry for the delay, there is a PR #2382 to support COW in Java client which includes the changes here.

Copy link
Author

@caidezhi caidezhi Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leesf if it is already covered by other PR, please feel free to close this one. Thanks for your review.

updateIndex(writeStatuses, result);
commitOnAutoCommit(result);
}

@Override
protected String getCommitActionType() {
return table.getMetaClient().getCommitActionType();
Expand Down