-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[MINOR] Removing spring repos from pom #2481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- These are being deprecated - Causes build issues when .m2 does not have this cached already
Member
Author
|
cc @xushiyan |
Codecov Report
@@ Coverage Diff @@
## master #2481 +/- ##
============================================
- Coverage 50.18% 50.17% -0.02%
Complexity 3050 3050
============================================
Files 419 419
Lines 18931 18931
Branches 1948 1948
============================================
- Hits 9500 9498 -2
- Misses 8656 8657 +1
- Partials 775 776 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vinothchandar
added a commit
that referenced
this pull request
Feb 18, 2021
- These are being deprecated - Causes build issues when .m2 does not have this cached already Co-authored-by: vinoth chandar <[email protected]>
vinothchandar
added a commit
that referenced
this pull request
Feb 18, 2021
- These are being deprecated - Causes build issues when .m2 does not have this cached already Co-authored-by: vinoth chandar <[email protected]>
vinothchandar
added a commit
that referenced
this pull request
Feb 18, 2021
- These are being deprecated - Causes build issues when .m2 does not have this cached already Co-authored-by: vinoth chandar <[email protected]>
vinothchandar
added a commit
that referenced
this pull request
Feb 18, 2021
- These are being deprecated - Causes build issues when .m2 does not have this cached already Co-authored-by: vinoth chandar <[email protected]>
vinothchandar
added a commit
that referenced
this pull request
Feb 18, 2021
- These are being deprecated - Causes build issues when .m2 does not have this cached already Co-authored-by: vinoth chandar <[email protected]>
asfgit
pushed a commit
to apache/submarine
that referenced
this pull request
Jun 20, 2021
…-jhyde ### What is this PR for? As KUAN-HSUN-LI said in the issue [SUBMARINE-838](https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-838?filter=allopenissues), if we remove our local maven cache (`~/.m2/`), maven will report as follows.  The root cause of the error is that the artifact `pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde`, one of the dependency jar files of Hive, is not accessible from the central maven repository anymore. At first, I tried to add new repositories, including **Spring Plugins Repository, Spring Lib M Repository, and Conjars Repository**, but all of these three repositories are being deprecated. Hence, **this artifact is accessible from none of the repositories anymore.** Because the method mentioned above does not work, jojochuang recommends excluding this missing artifact and making sure the exclusion will not break our Travis tests. Reference: (1) apache/hudi#160 (2) apache/hudi#2481 (3) apache/hudi@d02c0e5 ### What type of PR is it? [Bug Fix] ### Todos ### What is the Jira issue? https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-838?filter=allopenissues ### How should this be tested? * Step1: Local build ``` rm -r ~/.m2/ mvn clean install -DskipTests ``` * Step2: Travis * https://travis-ci.com/github/kevin85421/hadoop-submarine * Step3: Github action "Deploy submarine docker images" * When a new commit is merged to the master branch, this action will be triggered. ### Screenshots (if appropriate) * Step1: Local build <img width="865" alt="截圖 2021-06-20 上午10 51 22" src="https://user-images.githubusercontent.com/20109646/122660626-81173680-d1b5-11eb-94fb-fbcf7bfd0739.png"> * Step2: Travis * Pass all tests on travis-ci.com * https://travis-ci.com/github/kevin85421/hadoop-submarine ### Questions: * Do the license files need updating? No * Are there breaking changes for older versions? No * Does this need new documentation? No Author: Kai-Hsun Chen <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]> Closes #608 from kevin85421/SUBMARINE-838 and squashes the following commits: b7df29b [Kai-Hsun Chen] SUBMARINE-838. Failed to find org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde
prashantwason
pushed a commit
to prashantwason/incubator-hudi
that referenced
this pull request
Aug 5, 2021
- These are being deprecated - Causes build issues when .m2 does not have this cached already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.