Skip to content

Conversation

@vinothchandar
Copy link
Member

  • These are being deprecated
  • Causes build issues when .m2 does not have this cached already

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

 - These are being deprecated
 - Causes build issues when .m2 does not have this cached already
@vinothchandar vinothchandar changed the title Removing spring repos from pom [MINOR] Removing spring repos from pom Jan 24, 2021
@vinothchandar
Copy link
Member Author

cc @xushiyan

@codecov-io
Copy link

codecov-io commented Jan 24, 2021

Codecov Report

Merging #2481 (f67acf4) into master (e302c6b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2481      +/-   ##
============================================
- Coverage     50.18%   50.17%   -0.02%     
  Complexity     3050     3050              
============================================
  Files           419      419              
  Lines         18931    18931              
  Branches       1948     1948              
============================================
- Hits           9500     9498       -2     
- Misses         8656     8657       +1     
- Partials        775      776       +1     
Flag Coverage Δ Complexity Δ
hudicli 37.21% <ø> (ø) 0.00 <ø> (ø)
hudiclient 100.00% <ø> (ø) 0.00 <ø> (ø)
hudicommon 51.47% <ø> (-0.03%) 0.00 <ø> (ø)
hudiflink 0.00% <ø> (ø) 0.00 <ø> (ø)
hudihadoopmr 33.16% <ø> (ø) 0.00 <ø> (ø)
hudisparkdatasource 65.85% <ø> (ø) 0.00 <ø> (ø)
hudisync 48.61% <ø> (ø) 0.00 <ø> (ø)
huditimelineservice 66.49% <ø> (ø) 0.00 <ø> (ø)
hudiutilities 69.43% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...e/hudi/common/table/log/HoodieLogFormatWriter.java 78.12% <0.00%> (-1.57%) 26.00% <0.00%> (ø%)

@vinothchandar vinothchandar merged commit 81836f0 into apache:master Jan 24, 2021
vinothchandar added a commit that referenced this pull request Feb 18, 2021
- These are being deprecated
- Causes build issues when .m2 does not have this cached already

Co-authored-by: vinoth chandar <[email protected]>
vinothchandar added a commit that referenced this pull request Feb 18, 2021
- These are being deprecated
- Causes build issues when .m2 does not have this cached already

Co-authored-by: vinoth chandar <[email protected]>
vinothchandar added a commit that referenced this pull request Feb 18, 2021
- These are being deprecated
- Causes build issues when .m2 does not have this cached already

Co-authored-by: vinoth chandar <[email protected]>
vinothchandar added a commit that referenced this pull request Feb 18, 2021
- These are being deprecated
- Causes build issues when .m2 does not have this cached already

Co-authored-by: vinoth chandar <[email protected]>
vinothchandar added a commit that referenced this pull request Feb 18, 2021
- These are being deprecated
- Causes build issues when .m2 does not have this cached already

Co-authored-by: vinoth chandar <[email protected]>
asfgit pushed a commit to apache/submarine that referenced this pull request Jun 20, 2021
…-jhyde

### What is this PR for?
As KUAN-HSUN-LI said in the issue [SUBMARINE-838](https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-838?filter=allopenissues), if we remove our local maven cache (`~/.m2/`), maven will report as follows.

![image-2021-05-27-11-37-20-931](https://user-images.githubusercontent.com/20109646/122660236-8626b680-d1b2-11eb-84d8-e9e74d5eb5d9.png)

The root cause of the error is that the artifact `pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde`, one of the dependency jar files of Hive, is not accessible from the central maven repository anymore.

At first, I tried to add new repositories, including **Spring Plugins Repository, Spring Lib M Repository, and Conjars Repository**, but all of these three repositories are being deprecated. Hence, **this artifact is accessible from none of the repositories anymore.**

Because the method mentioned above does not work, jojochuang recommends excluding this missing artifact and making sure the exclusion will not break our Travis tests.

Reference:
(1) apache/hudi#160
(2) apache/hudi#2481
(3) apache/hudi@d02c0e5

### What type of PR is it?
[Bug Fix]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-838?filter=allopenissues

### How should this be tested?
* Step1: Local build
```
rm -r ~/.m2/
mvn clean install -DskipTests
```

* Step2: Travis
  * https://travis-ci.com/github/kevin85421/hadoop-submarine

* Step3: Github action "Deploy submarine docker images"
   * When a new commit is merged to the master branch, this action will be triggered.

### Screenshots (if appropriate)
* Step1: Local build
<img width="865" alt="截圖 2021-06-20 上午10 51 22" src="https://user-images.githubusercontent.com/20109646/122660626-81173680-d1b5-11eb-94fb-fbcf7bfd0739.png">

* Step2: Travis
  * Pass all tests on travis-ci.com
  * https://travis-ci.com/github/kevin85421/hadoop-submarine

### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No

Author: Kai-Hsun Chen <[email protected]>

Signed-off-by: Kai-Hsun Chen <[email protected]>

Closes #608 from kevin85421/SUBMARINE-838 and squashes the following commits:

b7df29b [Kai-Hsun Chen] SUBMARINE-838. Failed to find org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde
prashantwason pushed a commit to prashantwason/incubator-hudi that referenced this pull request Aug 5, 2021
- These are being deprecated
- Causes build issues when .m2 does not have this cached already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants