Skip to content

[MINOR] Rename FileSystemViewHandler to RequestHandler and corrected the class comment #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinothchandar merged 1 commit into from
Feb 2, 2021
Merged

[MINOR] Rename FileSystemViewHandler to RequestHandler and corrected the class comment #2458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...meline/service/FileSystemViewHandler.java → ...hudi/timeline/service/RequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,20 +50,20 @@
import java.util.stream.Collectors;

/**
* Main REST Handler class that handles local view staleness and delegates calls to slice/data-file/timeline handlers.
* Main REST Handler class that handles and delegates calls to timeline relevant handlers.
*/
public class FileSystemViewHandler {
public class RequestHandler {

private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
private static final Logger LOG = LogManager.getLogger(FileSystemViewHandler.class);
private static final Logger LOG = LogManager.getLogger(RequestHandler.class);

private final FileSystemViewManager viewManager;
private final Javalin app;
private final TimelineHandler instantHandler;
private final FileSliceHandler sliceHandler;
private final BaseFileHandler dataFileHandler;

public FileSystemViewHandler(Javalin app, Configuration conf, FileSystemViewManager viewManager) throws IOException {
public RequestHandler(Javalin app, Configuration conf, FileSystemViewManager viewManager) throws IOException {
this.viewManager = viewManager;
this.app = app;
this.instantHandler = new TimelineHandler(conf, viewManager);
Expand Down
4 changes: 2 additions & 2 deletions hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/TimelineService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,9 @@ private int startServiceOnPort(int port) throws IOException {

public int startService() throws IOException {
app = Javalin.create();
FileSystemViewHandler router = new FileSystemViewHandler(app, conf, fsViewsManager);
RequestHandler requestHandler = new RequestHandler(app, conf, fsViewsManager);
app.get("/", ctx -> ctx.result("Hello World"));
router.register();
requestHandler.register();
int realServerPort = startServiceOnPort(serverPort);
LOG.info("Starting Timeline server on port :" + realServerPort);
this.serverPort = realServerPort;
Expand Down