Skip to content

Conversation

@n3nash
Copy link
Contributor

@n3nash n3nash commented Jan 13, 2021

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

  • An incorrect method was being used to generate a new commit with data. There were 2 startCommit()s being called which was causing rollback to fail.

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@n3nash n3nash changed the title HUDI-1525 fix test hbase index [HUDI-1525]: fix test hbase index Jan 13, 2021
@n3nash n3nash changed the title [HUDI-1525]: fix test hbase index [HUDI-1525] Fix test hbase index Jan 13, 2021
Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n3nash n3nash merged commit e926c1a into apache:master Jan 13, 2021
prashantwason pushed a commit to prashantwason/incubator-hudi that referenced this pull request Feb 22, 2021
prashantwason pushed a commit to prashantwason/incubator-hudi that referenced this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants