[HUDI-1479] Use HoodieEngineContext to parallelize fetching of partiton paths #2417

umehrot2 · 2021-01-07T22:48:15Z

What is the purpose of the pull request

In HUDI-1510 we moved HoodieEngineContext so it can be used to parallelize fetching of partition paths from FileSystemBackedMetadata implementation. This PR actually uses it to do the parallelization.

In addition, we fix HoodieTableMetadata to create HoodieBackedTableMetadata or FileSystemBackedTableMetadata depending on whether metadata is enabled or not.

Committer checklist

Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

vinothchandar

Some comments. Looks promising!

...di-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java

hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java

vinothchandar · 2021-01-08T02:45:45Z

hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieMREngineContext.java

any reason why this cannot be in hudi-hadoop-mr?

Well it is being directly instantiated at a couple of places in hudi-common:

FileSystemViewManager: https://github.com/apache/hudi/pull/2417/files#diff-1fa21ae97e976db303c47571e7cb9c34e4f94719d482e537134e231b2e944388R167

HoodieBackedTableMetadata: https://github.com/apache/hudi/pull/2417/files#diff-7c43aea81a02b4f135452b50eaa36d5868081e72b37d43101ca9de1f9ebb5195R77

hudi-common does not depend on hudi-hadoop-mr. As per your other comment we can get rid of 1 if we pass the engine context from the caller side. But we should not get rid of 2 because we are treating HoodieEngineContext as the default engine context to instantiate. This constructor is being used from hud-cli for ex (does not depend on hudi-hadoop-mr:

https://github.com/apache/hudi/pull/2417/files#diff-b9829aa53bc2a7b0a655993df2c3c75d53f6a8e51f317753e51f27c63fc20341R165

https://github.com/apache/hudi/pull/2417/files#diff-b9829aa53bc2a7b0a655993df2c3c75d53f6a8e51f317753e51f27c63fc20341R197

So, if we want to treat it like a default engine context to be used would be better to keep in hudi-common.

But we should not get rid of 2 because we are treating HoodieEngineContext as the default engine context to instantiate

But that only depends on the interface right. hudi-cli has access to sparkContext right?

Yes but not all commands need spark context. It is created depending on the commands which truly need spark context.

Besides this, as discussed offline there is another issue which I encountered when I started to fetch hadoopConf from engineContext based on your other comment. It results in NPE at places when metadata table is created inside spark executor tasks because engineContext is not serializable and ends up null at executors. For such scenarios in HoodieTable where we create metadata table I will have to add a check to create a HoodieMREngineContext in case engine context is null. Thus hudi-client needs access to this as well. So based on what we agreed to, we need something like a HoodieLocalEngineContext that can be used at all these places and can sit in hudi-common.

hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java

vinothchandar · 2021-01-08T02:49:26Z

hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java

is this block verbatim the code @prashantwason had for parallelizing bootstrapping.. Prashant, can you also please help review this PR

Yeah I adapted the same code with some changes which optimize for this particular case of fetching only partition paths.

Can we add more tests to this piece of code? (previously it was just in the bootstrap part), not this is prime time.

As I had mentioned, that this is already tested through code paths like cleaner, and I did verify that TestCleaner for example fails if this would return incorrect partitions.

Adding specific tests for FileSystemBackedMetadata is tricky because spark context is not available in hudi-common. Perhaps, this can be done in a separate PR.

hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java

hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java

codecov-io · 2021-01-08T04:01:10Z

Codecov Report

Merging #2417 (03336c2) into master (368c1a8) will increase coverage by 0.23%.
The diff coverage is 56.33%.

@@             Coverage Diff              @@
##             master    #2417      +/-   ##
============================================
+ Coverage     50.53%   50.76%   +0.23%     
- Complexity     3032     3062      +30     
============================================
  Files           417      419       +2     
  Lines         18727    18777      +50     
  Branches       1917     1918       +1     
============================================
+ Hits           9463     9532      +69     
+ Misses         8489     8470      -19     
  Partials        775      775

Flag	Coverage Δ	Complexity Δ
hudicli	`37.26% <0.00%> (-0.02%)`	`0.00 <0.00> (ø)`
hudiclient	`100.00% <ø> (ø)`	`0.00 <ø> (ø)`
hudicommon	`52.06% <55.00%> (+0.44%)`	`0.00 <13.00> (ø)`
hudiflink	`10.20% <ø> (ø)`	`0.00 <ø> (ø)`
hudihadoopmr	`33.06% <66.66%> (+0.05%)`	`0.00 <0.00> (ø)`
hudisparkdatasource	`66.07% <ø> (-0.05%)`	`0.00 <ø> (ø)`
hudisync	`48.61% <ø> (ø)`	`0.00 <ø> (ø)`
huditimelineservice	`66.84% <ø> (ø)`	`0.00 <ø> (ø)`
hudiutilities	`69.43% <100.00%> (+0.01%)`	`0.00 <1.00> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
.../org/apache/hudi/cli/commands/MetadataCommand.java	`1.11% <0.00%> (-0.02%)`	`1.00 <0.00> (ø)`
...pache/hudi/common/config/HoodieMetadataConfig.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...c/main/java/org/apache/hudi/common/fs/FSUtils.java	`52.38% <0.00%> (+6.66%)`	`61.00 <0.00> (+6.00)`
.../hudi/common/table/view/FileSystemViewManager.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...va/org/apache/hudi/metadata/BaseTableMetadata.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...pache/hudi/metadata/HoodieBackedTableMetadata.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...he/hudi/metadata/HoodieMetadataFileSystemView.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
.../org/apache/hudi/metadata/HoodieTableMetadata.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...i/hadoop/utils/HoodieRealtimeInputFormatUtils.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...e/hudi/common/engine/LocalTaskContextSupplier.java	`20.00% <20.00%> (ø)`	`1.00 <1.00> (?)`
... and 16 more

lw309637554 · 2021-01-08T16:14:48Z

hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java

@umehrot2 hello, why not use spark EngineContext? Because hudi can run just use spark, many users environment just have spark , but not have mr.

Hudi has added support for other engines like Flink. Also HoodieSparkEngineContext cannot be used here this API is called inside individual map reduce tasks from engines like spark and hive. In case of spark, the individual tasks do not have access to spark context. The spark context is not serializable.

On a side note, we should move it to the hudi-hadoop-mr module or rename this to HoodieLocalEngine or something. Lets discuss the relocation in the other comment.

n3nash · 2021-01-10T07:32:55Z

hudi-common/src/test/java/org/apache/hudi/metadata/TestFileSystemBackedTableMetadata.java

@vinothchandar Does assumeDatePartitoning=true assume that all partitions are hoodie partitions (skips check for .hoodie_partition_metadata) ?

n3nash · 2021-01-10T07:33:32Z

@vinothchandar @umehrot2 Added a test class, can you ptal ?

vinothchandar

Few minor comments. LGTM overall.

@n3nash if you could address them and get CI to be happy.

If @umehrot2 and @prashantwason review we can land.
I will timeout tomorrow afternoon

vinothchandar · 2021-01-10T08:11:29Z

...lient/hudi-spark-client/src/test/java/org/apache/hudi/metadata/TestHoodieBackedMetadata.java

but these calls seem like they enable metadata? first arg of getWriteConfig(..)

The second arg is useFilelistingMetadata = false

vinothchandar · 2021-01-10T08:14:18Z

hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieLocalEngineContext.java

remove reference to map-reduce task in doc. This is just generic enough to be used from a single jvm. thats what it could say. Talking about MR is kind of misleading

On looking deeper, I refactored HoodieJavaEngineContext to hudi-common and remove HoodieLocalEngineContext

hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java

hudi-common/src/test/java/org/apache/hudi/metadata/TestFileSystemBackedTableMetadata.java

…ion paths

n3nash · 2021-01-10T20:52:50Z

@vinothchandar Addressed comments, moved HoodieJavaEngineContext to hudi-common and remove HoodieLocalEngineContext

vinothchandar · 2021-01-10T20:54:30Z

moved HoodieJavaEngineContext to hudi-common and remove HoodieLocalEngineContext

Let's not do this. Please revert back. We discussed this before and chose to deliberately keep HoodieJavaEngineContext untouched. Every other engine context lives with its client.

vinothchandar · 2021-01-11T00:38:31Z

@n3nash please drop me a ping once the CI is happy

vinothchandar

LGTM. just one comment for self. I ll fix it later.

vinothchandar · 2021-01-11T05:14:41Z

hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java

    if (metadata == null) {
-      metadata = HoodieTableMetadata.create(hadoopConfiguration.get(), config.getBasePath(), config.getSpillableMapBasePath(),
-          config.useFileListingMetadata(), config.getFileListingMetadataVerify(), config.isMetricsOn(), config.shouldAssumeDatePartitioning());
+      HoodieEngineContext engineContext = context;


a more elegant way to do this would be through a getEngineContext() method that reinits lazily

…on paths (apache#2417) * [HUDI-1479] Use HoodieEngineContext to parallelize fetching of partition paths * Adding testClass for FileSystemBackedTableMetadata Co-authored-by: Nishith Agarwal <[email protected]>

…pache#2185) Summary: [MINOR] Make sure factory method is used to instanciate DFSPathSelector (apache#2187) * Move createSourceSelector into DFSPathSelector factory method * Replace constructor call with factory method * Added some javadoc [HUDI-1330] handle prefix filtering at directory level (apache#2157) The current DFSPathSelector only ignore prefix(_, .) at the file level while files under subdirectories e.g. (.checkpoint/*) are still considered which result in bad-format exception during reading. [HUDI-1200] fixed NPE in CustomKeyGenerator (apache#2093) - config field is no longer transient in key generator - verified that the key generator object is shipped from the driver to executors, just the one time and reused for each record [HUDI-1209] Properties File must be optional when running deltastreamer (apache#2085) [MINOR] Fix caller to SparkBulkInsertCommitActionExecutor (apache#2195) Fixed calling the wrong constructor [HUDI-1326] Added an API to force publish metrics and flush them. (apache#2152) * [HUDI-1326] Added an API to force publish metrics and flush them. Using the added API, publish metrics after each level of the DAG completed in hudi-test-suite. * Code cleanups Co-authored-by: Vinoth Chandar <[email protected]> [HUDI-1118] Cleanup rollback files residing in .hoodie folder (apache#2205) [MINOR] Private the NoArgsConstructor of SparkMergeHelper and code clean (apache#2194) 1. Fix merge on read DAG to make docker demo pass (apache#2092) 1. Fix merge on read DAG to make docker demo pass (apache#2092) 2. Fix repeat_count, rollback node [HUDI-1274] Make hive synchronization supports hourly partition (apache#2122) [HUDI-1351] Improvements to the hudi test suite for scalability and repeated testing. (apache#2197) 1. Added the --clean-input and --clean-output parameters to clean the input and output directories before starting the job 2. Added the --delete-old-input parameter to deleted older batches for data already ingested. This helps keep number of redundant files low. 3. Added the --input-parallelism parameter to restrict the parallelism when generating input data. This helps keeping the number of generated input files low. 4. Added an option start_offset to Dag Nodes. Without ability to specify start offsets, data is generated into existing partitions. With start offset, DAG can control on which partition, the data is to be written. 5. Fixed generation of records for correct number of partitions - In the existing implementation, the partition is chosen as a random long. This does not guarantee exact number of requested partitions to be created. 6. Changed variable blacklistedFields to be a Set as that is faster than List for membership checks. 7. Fixed integer division for Math.ceil. If two integers are divided, the result is not double unless one of the integer is casted to double. [HUDI-1338] Adding Delete support to test suite framework (apache#2172) - Adding Delete support to test suite. Added DeleteNode Added support to generate delete records Use RateLimiter instead of sleep. Repartition WriteStatus to optimize Hbase index writes (apache#1484) [HUDI-912] Refactor and relocate KeyGenerator to support more engines (apache#2200) * [HUDI-912] Refactor and relocate KeyGenerator to support more engines * Rename KeyGenerators [HUDI-892] RealtimeParquetInputFormat skip adding projection columns if there are no log files (apache#2190) * [HUDI-892] RealtimeParquetInputFormat skip adding projection columns if there are no log files * [HUDI-892] for test * [HUDI-892] fix bug generate array from split * [HUDI-892] revert test log [HUDI-1352] Add FileSystemView APIs to query pending clustering operations (apache#2202) [HUDI-1375] Fix bug in HoodieAvroUtils.removeMetadataFields() method (apache#2232) Co-authored-by: Wenning Ding <[email protected]> [HUDI-1358] Fix Memory Leak in HoodieLogFormatWriter (apache#2217) [HUDI-1377] remove duplicate code (apache#2235) [HUDI-1327] Introduce base implemetation of hudi-flink-client (apache#2176) [HUDI-1400] Replace Operation enum with WriteOperationType (apache#2259) [HUDI-1384] Decoupling hive jdbc dependency when HIVE_USE_JDBC_OPT_KEY set false (apache#2241) [MINOR] clean up and add comments to flink client (apache#2261) [MINOR] Add apacheflink label (apache#2268) [HUDI-1393] Add compaction action in archive command (apache#2246) [HUDI-1364] Add HoodieJavaEngineContext to hudi-java-client (apache#2222) [HUDI-1396] Fix for preventing bootstrap datasource jobs from hanging via spark-submit (apache#2253) Co-authored-by: Wenning Ding <[email protected]> [HUDI-1358] Fix leaks in DiskBasedMap and LazyFileIterable (apache#2249) [HUDI-1392] lose partition info when using spark parameter basePath (apache#2243) Co-authored-by: zhang wen <[email protected]> [MINOR] refactor code in HoodieMergeHandle (apache#2272) [HUDI-1424] Write Type changed to BULK_INSERT when set ENABLE_ROW_WRITER_OPT_KEY=true (apache#2289) [HUDI-1373] Add Support for OpenJ9 JVM (apache#2231) * add supoort for OpenJ9 VM * add 32bit openJ9 * Pulled the memory layout specs into their own classes. [HUDI-1357] Added a check to validate records are not lost during merges. (apache#2216) - Turned off by default [HUDI-1196] Update HoodieKey when deduplicating records with global index (apache#2248) - Works only for overwrite payload (default) - Does not alter current semantics otherwise Co-authored-by: Ryan Pifer <[email protected]> [HUDI-1349] spark sql support overwrite use insert_overwrite_table (apache#2196) [HUDI-1343] Add standard schema postprocessor which would rewrite the schema using spark-avro conversion (apache#2192) Co-authored-by: liujh <[email protected]> [HUDI-1427] Fix FileAlreadyExistsException when set HOODIE_AUTO_COMMIT_PROP to true (apache#2295) [HUDI-1412] Make HoodieWriteConfig support setting different default … (apache#2278) * [HUDI-1412] Make HoodieWriteConfig support setting different default value according to engine type fix typo (apache#2308) Co-authored-by: Xi Chen <[email protected]> [HUDI-1040] Make Hudi support Spark 3 (apache#2208) * Fix flaky MOR unit test * Update Spark APIs to make it be compatible with both spark2 & spark3 * Refactor bulk insert v2 part to make Hudi be able to compile with Spark3 * Add spark3 profile to handle fasterxml & spark version * Create hudi-spark-common module & refactor hudi-spark related modules Co-authored-by: Wenning Ding <[email protected]> [MINOR] Throw an exception when keyGenerator initialization failed (apache#2307) [HUDI-1395] Fix partition path using FSUtils (apache#2312) Fixed the logic to get partition path in Copier and Exporter utilities. [HUDI-1445] Refactor AbstractHoodieLogRecordScanner to use Builder (apache#2313) [MINOR] Minor improve in IncrementalRelation (apache#2314) [HUDI-1439] Remove scala dependency from hudi-client-common (apache#2306) [HUDI-1428] Clean old fileslice is invalid (apache#2292) Co-authored-by: zhang wen <[email protected]> Co-authored-by: zhang wen <[email protected]> [HUDI-1448] Hudi dla sync support skip rt table syncing (apache#2324) [HUDI-1435] Fix bug in Marker File Reconciliation for Non-Partitioned datasets (apache#2301) [MINOR] Improve code readability by passing in the fileComparisonsRDD in bloom index (apache#2319) [HUDI-1376] Drop Hudi metadata cols at the beginning of Spark datasource writing (apache#2233) Co-authored-by: Wenning Ding <[email protected]> [MINOR] Fix error information in exception (apache#2341) [MINOR] Make QuickstartUtil generate random timestamp instead of 0 (apache#2340) [HUDI-1406] Add date partition based source input selector for Delta streamer (apache#2264) - Adds ability to list only recent date based partitions from source data. - Parallelizes listing for faster tailing of DFSSources [HUDI-1437] support more accurate spark JobGroup for better performance tracking (apache#2322) [HUDI-1470] Use the latest writer schema, when reading from existing parquet files in the hudi-test-suite (apache#2344) [HUDI-115] Adding DefaultHoodieRecordPayload to honor ordering with combineAndGetUpdateValue (apache#2311) * Added ability to pass in `properties` to payload methods, so they can perform table/record specific merges * Added default methods so existing payload classes are backwards compatible. * Adding DefaultHoodiePayload to honor ordering while merging two records * Fixing default payload based on feedback [HUDI-1419] Add base implementation for hudi java client (apache#2286) [MINOR] Pass root exception to HoodieKeyGeneratorException for more information (apache#2354) Co-authored-by: Xi Chen <[email protected]> [HUDI-1075] Implement simple clustering strategies to create ClusteringPlan and to run the plan [HUDI-1471] Make QuickStartUtils generate deletes according to specific ts (apache#2357) [HUDI-1485] Fix Deletes issued without any prior commits exception (apache#2361) [HUDI-1488] Fix Test Case Failure in TestHBaseIndex (apache#2365) [HUDI-1489] Fix null pointer exception when reading updated written bootstrap table (apache#2370) Co-authored-by: Wenning Ding <[email protected]> [HUDI-1451] Support bulk insert v2 with Spark 3.0.0 (apache#2328) Co-authored-by: Wenning Ding <[email protected]> - Added support for bulk insert v2 with datasource v2 api in Spark 3.0.0. [HUDI-1487] fix unit test testCopyOnWriteStorage random failed (apache#2364) [HUDI-1490] Incremental Query should work even when there are partitions that have no incremental changes (apache#2371) * Incremental Query should work even when there are partitions that have no incremental changes Co-authored-by: Sivabalan Narayanan <[email protected]> [HUDI-1331] Adding support for validating entire dataset and long running tests in test suite framework (apache#2168) * trigger rebuild * [HUDI-1156] Remove unused dependencies from HoodieDeltaStreamerWrapper Class (apache#1927) * Adding support for validating records and long running tests in test sutie framework * Adding partial validate node * Fixing spark session initiation in Validate nodes * Fixing validation * Adding hive table validation to ValidateDatasetNode * Rebasing with latest commits from master * Addressing feedback * Addressing comments Co-authored-by: lamber-ken <[email protected]> Co-authored-by: linshan-ma <[email protected]> [HUDI-1481] add structured streaming and delta streamer clustering unit test (apache#2360) [HUDI-1354] Block updates and replace on file groups in clustering (apache#2275) * [HUDI-1354] Block updates and replace on file groups in clustering * [HUDI-1354] Block updates and replace on file groups in clustering [HUDI-1350] Support Partition level delete API in HUDI (apache#2254) * [HUDI-1350] Support Partition level delete API in HUDI * [HUDI-1350] Support Partition level delete API in HUDI base InsertOverwriteCommitAction * [HUDI-1350] Support Partition level delete API in HUDI base InsertOverwriteCommitAction [HUDI-1495] Upgrade Flink version to 1.12.0 (apache#2384) [MINOR] Remove the duplicate code in AbstractHoodieWriteClient.startCommit (apache#2385) [HUDI-1398] Align insert file size for reducing IO (apache#2256) * [HUDI-1398] Align insert file size for reducing IO Co-authored-by: zhang wen <[email protected]> [HUDI-1484] Escape the partition value in HiveSyncTool (apache#2363) [HUDI-1474] Add additional unit tests to TestHBaseIndex (apache#2349) [HUDI-1147] Modify GenericRecordFullPayloadGenerator to generate vali… (apache#2045) * [HUDI-1147] Modify GenericRecordFullPayloadGenerator to generate valid timestamps Co-authored-by: Sivabalan Narayanan <[email protected]> [HUDI-1493] Fixed schema compatibility check for fields. (apache#2350) Some field types changes are allowed (e.g. int -> long) while maintaining schema backward compatibility within HUDI. The check was reversed with the reader schema being passed for the write schema. [MINOR] Update report_coverage.sh (apache#2396) [HUDI-1434] fix incorrect log file path in HoodieWriteStat (apache#2300) * [HUDI-1434] fix incorrect log file path in HoodieWriteStat * HoodieWriteHandle#close() returns a list of WriteStatus objs * Handle rolled-over log files and return a WriteStatus per log file written - Combined data and delete block logging into a single call - Lazily initialize and manage write status based on returned AppendResult - Use FSUtils.getFileSize() to set final file size, consistent with other handles - Added tests around returned values in AppendResult - Added validation of the file sizes returned in write stat Co-authored-by: Vinoth Chandar <[email protected]> [HUDI-1418] Set up flink client unit test infra (apache#2281) [MINOR] Sync UpsertPartitioner modify of HUDI-1398 to flink/java (apache#2390) Co-authored-by: zhang wen <[email protected]> [HUDI-1423] Support delete in hudi-java-client (apache#2353) [MINOR] Add maven profile to support skipping shade sources jars (apache#2358) Co-authored-by: Xi Chen <[email protected]> [HUDI-842] Implementation of HUDI RFC-15. - Introduced an internal metadata table, that stores file listings. - metadata table is kept upto date with - Fixed handling of CleanerPlan. - [HUDI-842] Reduce parallelism to speed up the test. - [HUDI-842] Implementation of CLI commands for metadata operations and lookups. - [HUDI-842] Extend rollback metadata to include the files which have been appended to. - [HUDI-842] Support for rollbacks in MOR Table. - MarkerBasedRollbackStrategy needs to correctly provide the list of files for which rollback blocks were appended. - [HUDI-842] Added unit test for rollback of partial commits (inflight but not completed yet). - [HUDI-842] Handled the error case where metadata update succeeds but dataset commit fails. - [HUDI-842] Schema evolution strategy for Metadata Table. Each type of metadata saved (FilesystemMetadata, ColumnIndexMetadata, etc.) will be a separate field with default null. The type of the record will identify the valid field. This way, we can grow the schema when new type of information is saved within in which still keeping it backward compatible. - [HUDI-842] Fix non-partitioned case and speedup initial creation of metadata table.Choose only 1 partition for jsc as the number of records is low (hundreds to thousands). There is more overhead of creating large number of partitions for JavaRDD and it slows down operations like WorkloadProfile. For the non-partitioned case, use "." as the name of the partition to prevent empty keys in HFile. - [HUDI-842] Reworked metrics pusblishing. - Code has been split into reader and writer side. HoodieMetadata code to be accessed by using HoodieTable.metadata() to get instance of metdata for the table. Code is serializable to allow executors to use the functionality. - [RFC-15] Add metrics to track the time for each file system call. - [RFC-15] Added a distributed metrics registry for spark which can be used to collect metrics from executors. This helps create a stats dashboard which shows the metadata table improvements in real-time for production tables. - [HUDI-1321] Created HoodieMetadataConfig to specify configuration for the metadata table. This is safer than full-fledged properties for the metadata table (like HoodieWriteConfig) as it makes burdensome to tune the metadata. With limited configuration, we can control the performance of the metadata table closely. [HUDI-1319][RFC-15] Adding interfaces for HoodieMetadata, HoodieMetadataWriter (apache#2266) - moved MetadataReader to HoodieBackedTableMetadata, under the HoodieTableMetadata interface - moved MetadataWriter to HoodieBackedTableMetadataWriter, under the HoodieTableMetadataWriter - Pulled all the metrics into HoodieMetadataMetrics - Writer now wraps the metadata, instead of extending it - New enum for MetadataPartitionType - Streamlined code flow inside HoodieBackedTableMetadataWriter w.r.t initializing metadata state - [HUDI-1319] Make async operations work with metadata table (apache#2332) - Changes the syncing model to only move over completed instants on data timeline - Syncing happens postCommit and on writeClient initialization - Latest delta commit on the metadata table is sufficient as the watermark for data timeline archival - Cleaning/Compaction use a suffix to the last instant written to metadata table, such that we keep the 1-1 - .. mapping between data and metadata timelines. - Got rid of a lot of the complexity around checking for valid commits during open of base/log files - Tests now use local FS, to simulate more failure scenarios - Some failure scenarios exposed HUDI-1434, which is needed for MOR to work correctly co-authored by: Vinoth Chandar <[email protected]> [HUDI-1450] Use metadata table for listing in HoodieROTablePathFilter (apache#2326) [HUDI-1394] [RFC-15] Use metadata table (if present) to get all partition paths (apache#2351) [HUDI-1469] Faster initialization of metadata table using parallelized listing. (apache#2343) * [HUDI-1469] Faster initialization of metadata table using parallelized listing which finds partitions and files in a single scan. * MINOR fixes Co-authored-by: Vinoth Chandar <[email protected]> [HUDI-1325] [RFC-15] Merge updates of unsynced instants to metadata table (apache#2342) [RFC-15] Fix partition key in metadata table when bootstrapping from file system (apache#2387) Co-authored-by: Ryan Pifer <[email protected]> [HUDI-1312] [RFC-15] Support for metadata listing for snapshot queries through Hive/SparkSQL (apache#2366) Co-authored-by: Ryan Pifer <[email protected]> [HUDI-1504] Allow log files generated during restore/rollback to be synced as well - TestHoodieBackedMetadata#testSync etc now run for MOR tables - HUDI-1502 is still pending and has issues for MOR/rollbacks - Also addressed bunch of code review comments. [HUDI-1498] Read clustering plan from requested file for inflight instant (apache#2389) [HUDI-1506] Fix wrong exception thrown in HoodieAvroUtils (apache#2405) [HUDI-1383] Fixing sorting of partition vals for hive sync computation (apache#2402) [HUDI-1507] Change timeline utils to support reading replacecommit metadata (apache#2407) [MINOR] Rename unit test package of hudi-spark3 from scala to java (apache#2411) [HUDI-1513] Introduce WriteClient#preWrite() and relocate metadata table syncing (apache#2413) - Syncing to metadata table, setting operation type, starting async cleaner done in preWrite() - Fixes an issues where delete() was not starting async cleaner correctly - Fixed tests and enabled metadata table for TestAsyncCompaction [HUDI-1510] Move HoodieEngineContext and its dependencies to hudi-common (apache#2410) [MINOR] Sync HUDI-1196 to FlinkWriteHelper (apache#2415) [HUDI-1514] Avoid raw type use for parameter of Transformer interface (apache#2420) [HUDI-920] Support Incremental query for MOR table (apache#1938) [HUDI-1276] [HUDI-1459] Make Clustering/ReplaceCommit and Metadata table be compatible (apache#2422) * [HUDI-1276] [HUDI-1459] Make Clustering/ReplaceCommit and Metadata table be compatible * Use filesystemview and json format from metadata. Add tests Co-authored-by: Satish Kotha <[email protected]> [HUDI-1399] support a independent clustering spark job to asynchronously clustering (apache#2379) * [HUDI-1481] add structured streaming and delta streamer clustering unit test * [HUDI-1399] support a independent clustering spark job to asynchronously clustering * [HUDI-1399] support a independent clustering spark job to asynchronously clustering * [HUDI-1498] Read clustering plan from requested file for inflight instant (apache#2389) * [HUDI-1399] support a independent clustering spark job with schedule generate instant time Co-authored-by: satishkotha <[email protected]> [MINOR] fix spark 3 build for incremental query on MOR (apache#2425) [HUDI-1479] Use HoodieEngineContext to parallelize fetching of partiton paths (apache#2417) * [HUDI-1479] Use HoodieEngineContext to parallelize fetching of partition paths * Adding testClass for FileSystemBackedTableMetadata Co-authored-by: Nishith Agarwal <[email protected]> [HUDI-1520] add configure for spark sql overwrite use INSERT_OVERWRITE_TABLE (apache#2428) [HUDI-1502] MOR rollback and restore support for metadata sync (apache#2421) - Adds field to RollbackMetadata that capture the logs written for rollback blocks - Adds field to RollbackMetadata that capture new logs files written by unsynced deltacommits Co-authored-by: Vinoth Chandar <[email protected]> Reviewers: O955 Project Hoodie Project Reviewer: Add blocking reviewers!, PHID-PROJ-pxfpotkfgkanblb3detq!, #ldap_hudi, modi Reviewed By: #ldap_hudi, modi Differential Revision: https://code.uberinternal.com/D5347141

umehrot2 assigned vinothchandar Jan 7, 2021

vinothchandar reviewed Jan 8, 2021

View reviewed changes

lw309637554 reviewed Jan 8, 2021

View reviewed changes

umehrot2 force-pushed the hudi-1479 branch from 145372c to 0d706dd Compare January 9, 2021 02:32

n3nash reviewed Jan 10, 2021

View reviewed changes

vinothchandar reviewed Jan 10, 2021

View reviewed changes

[HUDI-1479] Use HoodieEngineContext to parallelize fetching of partit…

e95dfcb

…ion paths

n3nash force-pushed the hudi-1479 branch from 31da49f to 174edd7 Compare January 10, 2021 20:51

n3nash force-pushed the hudi-1479 branch 6 times, most recently from ad815be to 7bef2da Compare January 10, 2021 23:33

Adding testClass for FileSystemBackedTableMetadata

03336c2

n3nash force-pushed the hudi-1479 branch from 7bef2da to 03336c2 Compare January 11, 2021 02:20

vinothchandar approved these changes Jan 11, 2021

View reviewed changes

vinothchandar merged commit 7ce3ac7 into apache:master Jan 11, 2021

[HUDI-1479] Use HoodieEngineContext to parallelize fetching of partiton paths #2417

[HUDI-1479] Use HoodieEngineContext to parallelize fetching of partiton paths #2417

Uh oh!

Conversation

umehrot2 commented Jan 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is the purpose of the pull request

Committer checklist

Uh oh!

vinothchandar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov-io commented Jan 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

n3nash commented Jan 10, 2021

Uh oh!

vinothchandar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

n3nash commented Jan 10, 2021

Uh oh!

vinothchandar commented Jan 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinothchandar commented Jan 11, 2021

Uh oh!

vinothchandar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

umehrot2 commented Jan 7, 2021 •

edited

Loading

codecov-io commented Jan 8, 2021 •

edited

Loading

vinothchandar commented Jan 10, 2021 •

edited

Loading