Skip to content

[HUDI-1398] Align insert file size for reducing IO #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsivabalan merged 3 commits into from
Dec 29, 2020
Merged

[HUDI-1398] Align insert file size for reducing IO #2256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2abc495
[HUDI-1398] Align insert file size for reducing IO
Nov 17, 2020
a5cfea0
Merge remote-tracking branch 'upstream/master' into HUDI-1398
Dec 28, 2020
11a1f80
[HUDI-1398] Align insert file size for reducing IO
Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...udi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,11 @@ private void assignInserts(WorkloadProfile profile, HoodieEngineContext context)
+ ", totalInsertBuckets => " + insertBuckets + ", recordsPerBucket => " + insertRecordsPerBucket);
for (int b = 0; b < insertBuckets; b++) {
bucketNumbers.add(totalBuckets);
recordsPerBucket.add(totalUnassignedInserts / insertBuckets);
if (b < insertBuckets - 1) {
recordsPerBucket.add(insertRecordsPerBucket);
} else {
recordsPerBucket.add(totalUnassignedInserts - (insertBuckets - 1) * insertRecordsPerBucket);
}
BucketInfo bucketInfo = new BucketInfo();
bucketInfo.bucketType = BucketType.INSERT;
bucketInfo.partitionPath = partitionPath;
Expand Down
19 changes: 17 additions & 2 deletions ...spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,21 @@ public void testUpsertPartitioner() throws Exception {
assertEquals(2, insertBuckets.size(), "Total of 2 insert buckets");
}

@Test
public void testUpsertPartitionerWithRecordsPerBucket() throws Exception {
final String testPartitionPath = "2016/09/26";
// Inserts + Updates... Check all updates go together & inserts subsplit
UpsertPartitioner partitioner = getUpsertPartitioner(0, 250, 100, 1024, testPartitionPath, false);
List<InsertBucketCumulativeWeightPair> insertBuckets = partitioner.getInsertBuckets(testPartitionPath);
int insertSplitSize = partitioner.config.getCopyOnWriteInsertSplitSize();
int remainedInsertSize = 250 - 2 * insertSplitSize;
// will assigned 3 insertBuckets. 100, 100, 50 each
assertEquals(3, insertBuckets.size(), "Total of 3 insert buckets");
assertEquals(0.4, insertBuckets.get(0).getLeft().weight, "insert " + insertSplitSize + " records");
assertEquals(0.4, insertBuckets.get(1).getLeft().weight, "insert " + insertSplitSize + " records");
assertEquals(0.2, insertBuckets.get(2).getLeft().weight, "insert " + remainedInsertSize + " records");
}

@Test
public void testPartitionWeight() throws Exception {
final String testPartitionPath = "2016/09/26";
Expand Down Expand Up @@ -286,8 +301,8 @@ public void testUpsertPartitionerWithSmallInsertHandling() throws Exception {
"Bucket 3 is INSERT");
assertEquals(4, insertBuckets.size(), "Total of 4 insert buckets");

weights = new Double[] { 0.08, 0.31, 0.31, 0.31};
cumulativeWeights = new Double[] { 0.08, 0.39, 0.69, 1.0};
weights = new Double[] { 0.08, 0.42, 0.42, 0.08};
cumulativeWeights = new Double[] { 0.08, 0.5, 0.92, 1.0};
assertInsertBuckets(weights, cumulativeWeights, insertBuckets);
}

Expand Down