[HUDI-898] Add new backwards compatible API to expose schema in preCombine #2141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaradar
commented
Oct 2, 2020
Contributor
Author
There was a problem hiding this comment.
Made this to a class to take advantatage of lazy creation of Schema in executors.
| * @return Combined Record. | ||
| */ | ||
| @PublicAPIMethod(maturity = ApiMaturityLevel.STABLE) | ||
| default T preCombine(T another, Schema schema) { |
Member
There was a problem hiding this comment.
Could we just introduce a config that simply uses combineAndGetUpdateValue() to perform the preCombine as well. We have debated doing this for a while. Do you see a reason not to do something like that.
Closed
5 tasks
Member
|
cc @Karl-WangSK @bvaradar please see the other PR #2106 for a similar discussion. |
Contributor
Contributor
|
@bvaradar : can you check my previous comment. We can close this out if not required. If not, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to let users implement custom deduping-merge logic.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.