Skip to content

[HUDI-995] Migrate HoodieTestUtils APIs to HoodieTestTable#2112

Merged
yanghua merged 1 commit intoapache:masterfrom
xushiyan:use-test-table-3
Sep 26, 2020
Merged

[HUDI-995] Migrate HoodieTestUtils APIs to HoodieTestTable#2112
yanghua merged 1 commit intoapache:masterfrom
xushiyan:use-test-table-3

Conversation

@xushiyan
Copy link
Member

@xushiyan xushiyan commented Sep 24, 2020

Remove APIs in HoodieTestUtils

  • HoodieTestUtils#createInflightCommitFiles
  • HoodieTestUtils#getCommitFilePath
  • HoodieTestUtils#doesCommitExist

and migrate usages to HoodieTestTable in

  • hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRollbacksCommand.java
  • hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestUpgradeDowngradeCommand.java
  • hudi-cli/src/test/java/org/apache/hudi/cli/integ/ITTestCommitsCommand.java
  • hudi-cli/src/test/java/org/apache/hudi/cli/testutils/HoodieTestCommitMetadataGenerator.java
  • hudi-client/src/test/java/org/apache/hudi/client/TestHoodieClientOnCopyOnWriteStorage.java

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Remove APIs in HoodieTestUtils

- HoodieTestUtils#createInflightCommitFiles
- HoodieTestUtils#getCommitFilePath
- HoodieTestUtils#doesCommitExist

and migrate usages to HoodieTestTable in

- hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRollbacksCommand.java
- hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestUpgradeDowngradeCommand.java
- hudi-cli/src/test/java/org/apache/hudi/cli/integ/ITTestCommitsCommand.java
- hudi-cli/src/test/java/org/apache/hudi/cli/testutils/HoodieTestCommitMetadataGenerator.java
- hudi-client/src/test/java/org/apache/hudi/client/TestHoodieClientOnCopyOnWriteStorage.java
@xushiyan xushiyan requested a review from yanghua September 25, 2020 08:45
@xushiyan xushiyan marked this pull request as ready for review September 25, 2020 08:45
@yanghua yanghua self-assigned this Sep 25, 2020
Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xushiyan Left one comment.

Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yanghua yanghua merged commit 1be0b06 into apache:master Sep 26, 2020
@xushiyan xushiyan deleted the use-test-table-3 branch September 26, 2020 16:52
prashantwason pushed a commit to prashantwason/incubator-hudi that referenced this pull request Feb 22, 2021
Remove APIs in HoodieTestUtils

- HoodieTestUtils#createInflightCommitFiles
- HoodieTestUtils#getCommitFilePath
- HoodieTestUtils#doesCommitExist

and migrate usages to HoodieTestTable in

- hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRollbacksCommand.java
- hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestUpgradeDowngradeCommand.java
- hudi-cli/src/test/java/org/apache/hudi/cli/integ/ITTestCommitsCommand.java
- hudi-cli/src/test/java/org/apache/hudi/cli/testutils/HoodieTestCommitMetadataGenerator.java
- hudi-client/src/test/java/org/apache/hudi/client/TestHoodieClientOnCopyOnWriteStorage.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants