Skip to content

Conversation

@bvaradar
Copy link
Contributor

No description provided.

@bvaradar
Copy link
Contributor Author

@nsivabalan : Can you please review this.

Thanks,
Balaji.V

@tooptoop4
Copy link

I thought #1792 fixed it?

@bvaradar
Copy link
Contributor Author

@tooptoop4 : The issue was still there. I added a testcase (testPreCombineWithDelete) which would fail with existing code but passes with this PR.

@nsivabalan
Copy link
Contributor

yeah, #1792 fixed the issue for OverwriteWithLatestAvroPayload and not for AWSDmsAvroPayload. thanks @bvaradar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants