[HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long#2071
Merged
n3nash merged 1 commit intoapache:masterfrom Sep 16, 2020
Merged
[HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long#2071n3nash merged 1 commit intoapache:masterfrom
n3nash merged 1 commit intoapache:masterfrom
Conversation
shenh062326
force-pushed
the
HUDI-1143
branch
from
fdd5bfc to
541746e
Compare
shenh062326
force-pushed
the
HUDI-1143
branch
from
541746e to
1929b7b
Compare
Contributor
Author
|
@n3nash can you take a look at this MR. |
Contributor
|
@shenh062326 The PR looks fine to me, high level, what is the reason for this change ? Is it just to correct timestamp types ? |
Contributor
Author
The Description in https://issues.apache.org/jira/browse/HUDI-1143 explain the reason: |
Contributor
|
@shenh062326 thanks for explaining. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.