Skip to content

Conversation

@lw309637554
Copy link
Contributor

Tips

What is the purpose of the pull request

Abstract hudi-sync-common ,and migrate the hudi-hive-sync to hudi-sync-hive. hudi-sync-hive implement the hudi-sync-common .

Then will support hudi-sync-aliyun-dla implement the hudi-sync-common .

This is the RFC https://cwiki.apache.org/confluence/display/HUDI/RFC+-+17+Abstract+common+meta+sync+module+support+multiple+meta+service.

And the old PR is #1716 ,which just abstract the hudi-sync-common.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@lw309637554
Copy link
Contributor Author

@vinothchandar hello ,as discussion in #1593. I submit a PR with the hudi-sync-common and reconstruct the old hudi-hive-sync to hudi-sync-hive which implements hudi-sync-common. Please review it.

@vinothchandar
Copy link
Member

@lw309637554 can you please check CI failure?

Before diving in, are there any backwards compatible changes/special upgrade instructions needed for users with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants