[HUDI-1069] Remove duplicate assertNoWriteErrors() #1797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
changed the title
xushiyan
force-pushed
the
add-assertions-helpers
branch
from
075c563 to
c05f781
Compare
xushiyan
force-pushed
the
add-assertions-helpers
branch
from
25cf4ac to
cd4d5f2
Compare
Member
Author
|
@yanghua this is ready for review. Thanks. |
yanghua
reviewed
Jul 8, 2020
Contributor
There was a problem hiding this comment.
Hi @xushiyan I have a concern about open this method. Currently, @wangxianghu is refactoring client module #1727 . He is trying to decouple the dependency with Spark APIs. Maybe we'd better have this interface:
public static void assertNoWriteErrors(List<WriteStatus> statuses) {
//...
}
WDYT?
Member
Author
There was a problem hiding this comment.
Ok that method is also there. just need to remove the overloading version for RDD. changing it now.
Contributor
There was a problem hiding this comment.
Thanks for addressing my concern.
- Assertions.java for common assertions - refactor assertNoWriteErrors()
xushiyan
force-pushed
the
add-assertions-helpers
branch
from
cd4d5f2 to
fcd087b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.