-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-5533] Support spark nested columns comments #14235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
de214ce to
37809ac
Compare
f9f84ee to
864a9ad
Compare
feat: support nested doc in hms datasource fix fix wip wip
72ab191 to
236b589
Compare
236b589 to
86ffe68
Compare
|
@yihua what about also landing this into 1.1 ? |
|
also maybe @danny0405 as you did follow this topic previously and this touch a bit to flink too |
|
@parisni The 1.1 RC2 is out, I don't think this is a blocker for it, I can help for the review though, can you check the test failures? |
|
@danny0405 i did fix the tests. still some are failing but sounds like flaky tests ?
|
yihua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parisni Could you rebase your branch on top of the latest master? A few fixes on CI flakiness have been merged.
|
Hi @yihua @danny0405 i did rebase on master again |
feat: support nested doc datasource. improvement of #8683
Goal:
Full comments support for hudi, from source to target
Context:
as of 1.x and previous, the field comment support is partial:
What this PR covers:
Reminder:
[hoodie.datasource.hive_sync.sync_as_datasource](https://hudi.apache.org/docs/0.15.0/configurations#hoodiedatasourcehive_syncsync_as_datasource)Describe the issue this Pull Request addresses
Summary and Changelog
Impact
Risk Level
Documentation Update
Contributor's checklist