Skip to content

Conversation

@alexr17
Copy link
Contributor

@alexr17 alexr17 commented Aug 12, 2025

Change Logs

Adds a heartbeat manager for the lock provider with conditional writes. Original PR is here: #12958

See RFC: #12927

Impact

This heartbeat manager is responsible for maintaining a thread which constantly updates the lock file in storage.

The heartbeat manager runs on a thread in same jvm as lock manager/writer client. This allows us to abstract away maintaining the lock from the lock provider. From the perspective of lock provider, all it does is call heartbeatManager.startHeartbeatForThread(Thread.currentThread()).

Risk level (write none, low medium or high below)

None

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

None

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@alexr17 alexr17 changed the base branch from master to branch-0.x August 12, 2025 05:45
@github-actions github-actions bot added the size:L PR with lines of changes in (300, 1000] label Aug 12, 2025
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit afe7ea6 into apache:branch-0.x Aug 12, 2025
2 checks passed
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexr17 added a commit to alexr17/hudi that referenced this pull request Aug 13, 2025
alexr17 added a commit to alexr17/hudi that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L PR with lines of changes in (300, 1000]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants