Skip to content

Conversation

@voonhous
Copy link
Member

@voonhous voonhous commented Jun 27, 2025

Change Logs

Migrating trino-hudi repository to hudi repository.

The migration is done as such:

  1. Move trino-hudi from OSS entirely at hash: 1046d9a5410207bd7f79c12cf74949a7221e333b
  2. Move trino-hudi from OHI entirely at hash: a56b8014a3fe2edeb00330522cf471384bc6fbd1

Caveats

As OHI is using trino-472, a few things have to be reverted from OSS and they are:

  1. Replace ConnectorContext getNodeManager with getCurrentNode if possible #26096
    • This mainly affects HudiConnectorFactory.java
  2. Avoid reading unusually large parquet footers #25973
    • This mainly affects one line in HudiPageSourceProvider.java where options.getMaxFooterReadSize() can be passed to readFooter.

Impact

None

Risk level (write none, low medium or high below)

None

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@voonhous voonhous force-pushed the trino-master-hudi-fork-2025-04-28-voon1 branch 2 times, most recently from 01ecb20 to 4a1d160 Compare June 27, 2025 08:11
@github-actions github-actions bot added the size:XL PR with lines of changes > 1000 label Jun 27, 2025
@voonhous voonhous force-pushed the trino-master-hudi-fork-2025-04-28-voon1 branch from c4ba141 to 4a1d160 Compare June 27, 2025 08:23
@voonhous
Copy link
Member Author

Azure CI failures: UT FT common & other modules

@voonhous voonhous force-pushed the trino-master-hudi-fork-2025-04-28-voon1 branch 7 times, most recently from 0eb809c to 165aa40 Compare June 27, 2025 14:53
@voonhous voonhous closed this Jun 30, 2025
@voonhous voonhous reopened this Jun 30, 2025
@voonhous voonhous force-pushed the trino-master-hudi-fork-2025-04-28-voon1 branch from e58ac58 to e04fd9c Compare June 30, 2025 08:53
@voonhous voonhous closed this Jun 30, 2025
@voonhous voonhous reopened this Jun 30, 2025
@voonhous voonhous force-pushed the trino-master-hudi-fork-2025-04-28-voon1 branch 3 times, most recently from ed637d2 to 7135e38 Compare June 30, 2025 11:25
@voonhous voonhous marked this pull request as draft June 30, 2025 12:11
@voonhous voonhous force-pushed the trino-master-hudi-fork-2025-04-28-voon1 branch 5 times, most recently from 1724ff1 to 6f7d59a Compare July 1, 2025 11:41
@voonhous voonhous force-pushed the trino-master-hudi-fork-2025-04-28-voon1 branch from 78ec44e to 39e0bfb Compare July 30, 2025 15:00
@voonhous voonhous closed this Jul 30, 2025
@voonhous voonhous reopened this Jul 30, 2025
@voonhous
Copy link
Member Author

@hudi-bot run azure

@voonhous voonhous force-pushed the trino-master-hudi-fork-2025-04-28-voon1 branch from 39e0bfb to 3a2605b Compare July 31, 2025 01:51
@voonhous voonhous closed this Jul 31, 2025
@voonhous voonhous reopened this Jul 31, 2025
@voonhous voonhous marked this pull request as ready for review July 31, 2025 03:00
@voonhous voonhous requested a review from yihua July 31, 2025 12:29
@hudi-bot
Copy link

hudi-bot commented Aug 6, 2025

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the code in this PR and plugin/trino-hudi from OHI at hash: a56b8014a3fe2edeb00330522cf471384bc6fbd1. The code is the same except the required changes from onehouseinc/trino#46.

I made minor revisions on the licence checking, bot.yml, etc.

LGTM

@yihua
Copy link
Contributor

yihua commented Aug 6, 2025

Java CI / validate-source and Java CI / test-hudi-trino-plugin pass. Other CI jobs are not affected. Merging this PR.

@yihua yihua merged commit 4e987fe into apache:master Aug 6, 2025
60 of 61 checks passed
@voonhous voonhous deleted the trino-master-hudi-fork-2025-04-28-voon1 branch August 7, 2025 02:32
alexr17 pushed a commit to alexr17/hudi that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL PR with lines of changes > 1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants