Skip to content

[HUDI-9414] Moved bulk insert tests to hudi-spark#13306

Merged
yihua merged 1 commit intoapache:masterfrom
wombatu-kun:HUDI-9414_dedup_bulkinsert_tests
May 16, 2025
Merged

[HUDI-9414] Moved bulk insert tests to hudi-spark#13306
yihua merged 1 commit intoapache:masterfrom
wombatu-kun:HUDI-9414_dedup_bulkinsert_tests

Conversation

@wombatu-kun
Copy link
Copy Markdown
Contributor

@wombatu-kun wombatu-kun commented May 15, 2025

Change Logs

Addressing this comment #13301 (comment)
Follow-up of this PR #13301 (moving code from spark3-common to spark-common) and prerequisite for #12772 (Spark 4 support)
These tests are identical in version-specific spark modules, so i moved them to hudi-spark.
It's good to merge it before Spark 4 support.

Impact

avoid test code duplication across version-specific modules

Risk level (write none, low medium or high below)

none

Documentation Update

none

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@wombatu-kun
Copy link
Copy Markdown
Contributor Author

hey guys! @danny0405 @yihua @voonhous help me to merge it please (i need it to continue Spark 4 support PR)
easy PR: no changes in file's content, just 3 tests moved and 6 removed.

@hudi-bot
Copy link
Copy Markdown
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the clean-up!

@yihua yihua merged commit 11fd91c into apache:master May 16, 2025
59 checks passed
wombatu-kun added a commit to wombatu-kun/hudi that referenced this pull request May 16, 2025
Co-authored-by: Vova Kolmakov <kolmakov.vladimir@huawei.com>
(cherry picked from commit 11fd91c)
alexr17 pushed a commit to alexr17/hudi that referenced this pull request Aug 25, 2025
Co-authored-by: Vova Kolmakov <kolmakov.vladimir@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL PR with lines of changes > 1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants