[HUDI-8902] Fix schema evolution from float to double for avro log blocks #13289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonvex
changed the title
github-actions
bot
added
size:S
Collaborator
danny0405
approved these changes
May 14, 2025
alexr17
pushed a commit
to alexr17/hudi
that referenced
this pull request
Aug 25, 2025
…ocks (apache#13289) * fix for avro log blocks and for vectorized reader * add test and revert vectorized change --------- Co-authored-by: Jonathan Vexler <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
The precision is incorrect for evolution from float to double and has been fixed for most of spark by #13188. However, there are some edge cases that still need to be fixed.
This pr fixes avro log blocks the evolution is fixed by adding the float -> double conversion into the method that determines if we need to manually convert the record (and the manual conversion already has the float->double conversion correct)
Impact
Fix float -> double precision issue for avro log blocks
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist