Skip to content

Conversation

@lamberken
Copy link
Member

What is the purpose of the pull request

  1. Unify code indent ( 4 -> 2 )
  2. Change org.apache.hudi to hudi
  3. Fix hudi_ro_table not exists at Delete section

Verify this pull request

Compare changes

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Copy link
Contributor

@bhasudha bhasudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lamber-ken just confirming - were you able to verify the spark.read.format("org.apache.hudi") to spark.read.format"hudi") change ?

I left couple minor comments. Otherwise looks good.

@lamberken
Copy link
Member Author

lamberken commented Feb 5, 2020

Hi @bhasudha, I did and verify that "org.apache.hudi" to "hudi" #1054

@lamberken
Copy link
Member Author

hi @bhasudha, all review comments are addressed and fixed. :)

@bhasudha
Copy link
Contributor

hi @bhasudha, all review comments are addressed and fixed. :)

Hi @lamber-ken . I am having some doc changes that pertain to cutting 0.5.1 doc version directory. I ll send those PRs first and later merge this change so that 0.5.1 doc version does not contain newer changes.

The changes here looks okay. I am just waiting on those changes first to go in. Thanks!

@lamberken
Copy link
Member Author

hi @bhasudha, all review comments are addressed and fixed. :)

Hi @lamber-ken . I am having some doc changes that pertain to cutting 0.5.1 doc version directory. I ll send those PRs first and later merge this change so that 0.5.1 doc version does not contain newer changes.

The changes here looks okay. I am just waiting on those changes first to go in. Thanks!

Okay, got. :)

@bhasudha
Copy link
Contributor

bhasudha commented Mar 6, 2020

Merging this since 0.5.1 doc release is cut.

@bhasudha bhasudha merged commit 35b0aef into apache:asf-site Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants