[HUDI-9155] Add scaffolding for lock provider using conditional writes #12954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/models/ConditionalWriteLockData.java:36
- [nitpick] Consider rephrasing the comment for the owner parameter to: 'The UUID of the owner of this lock.'
* @param owner The uuid owner of the owner of this lock.
vinothchandar
approved these changes
Apr 7, 2025
Member
vinothchandar
left a comment
vinothchandar
left a comment
There was a problem hiding this comment.
Minor naming comments..
...ommon/src/main/java/org/apache/hudi/client/transaction/lock/ConditionalWriteLockService.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/org/apache/hudi/client/transaction/lock/ConditionalWriteLockService.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/apache/hudi/client/transaction/lock/models/ConditionalWriteLockData.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/apache/hudi/client/transaction/lock/models/ConditionalWriteLockFile.java
Outdated
Show resolved
Hide resolved
...lient-common/src/main/java/org/apache/hudi/client/transaction/lock/models/LockGetResult.java
Outdated
Show resolved
Hide resolved
Contributor
|
@hudi-bot run azure |
Contributor
Author
|
@hudi-bot run azure |
1 similar comment
Contributor
|
@hudi-bot run azure |
Contributor
Author
|
@hudi-bot run azure |
alexr17
changed the title
Contributor
Author
|
@hudi-bot run azure |
Collaborator
4 tasks
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 8, 2025
apache#12954) (cherry picked from commit 075a9a4)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 9, 2025
apache#12954) (cherry picked from commit 075a9a4)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 11, 2025
apache#12954) (cherry picked from commit 075a9a4)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 15, 2025
apache#12954) (cherry picked from commit 075a9a4)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 16, 2025
apache#12954) (cherry picked from commit 075a9a4)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This is the 1st PR for the
ConditionalWriteLockProvider. This adds an interface,ConditionalWriteLockServiceand various supplemental models. The main lock provider algorithm will be added inConditionalWriteLockProviderhowever we define the contract for our pluggable storage format here to make it clear what is not being abstracted away.Each
ConditionalWriteLockFilepayload will be written to object storage, and we add several helper methods in this PR to ensure the calling storage client apis can serialize and deserialize the payload.See RFC: #12927
Impact
None.
Risk level (write none, low medium or high below)
None.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
None
Contributor's checklist