Skip to content

Conversation

@lamberken
Copy link
Member

@lamberken lamberken commented Jan 9, 2020

What is the purpose of the pull request

Feedback Record #1196 .

Quick review, please visit https://lamber-ken.github.io .

  • Fix some broken links in Quickstart.
  • Reduce font size by one pixel in the new website.
  • Chinese docs is a big work, already support.

Worked with ApacheCN, finished the work of chinese translation, please visit https://hudi.apachecn.org/docs/0.5.0 .

image

image

image

Brief change log

  • Fix some broken links in Quickstart.
  • Reduce font size by one pixel in the new website.
  • Chinese docs is a big work, not included.

Verify this pull request

This pull request is optimize work on the new website.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@lamberken lamberken marked this pull request as ready for review January 11, 2020 01:02
Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lamber-ken seems like this PR also deletes/moves a lot more files? can you please describe all the changes here in the PR.. Also could you please scope this PR to just update on the *md files? (without the generated html content).. That will help review more incrementally... its just a very large PR to chew and I am having a hard time understanding how the 3 things you describe in changelog can cause such a large change

@vinothchandar vinothchandar self-assigned this Jan 12, 2020
@lamberken
Copy link
Member Author

lamberken commented Jan 12, 2020

hi @vinothchandar, thanks for your review.

I cleaned old site and tmp site files.

  • 1, Remove docs-tmp, which is a middle docs contains old-site and new-site
  • 2, Move docs-new to docs
    image

@lamberken
Copy link
Member Author

hi @vinothchandar, thanks for your advice, all review comments are addressed and fixed.

Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is just fixing a new things for new site and also porting over the chinese pages from old site? How does this work relate to the apachecn page?

Side note: What purpose does docs-tmp solve.. We should make a plan to retire the old site and switch over to the new one early next week.. can you please outline the steps needed for that in a separate JIRA and we hash out a plan first.

@lamberken
Copy link
Member Author

lamberken commented Jan 12, 2020

So this is just fixing a new things for new site and also porting over the chinese pages from old site? How does this work relate to the apachecn page?

Side note: What purpose does docs-tmp solve.. We should make a plan to retire the old site and switch over to the new one early next week.. can you please outline the steps needed for that in a separate JIRA and we hash out a plan first.

Hi, @vinothchandar

1, ApacheCN page can help to promote hudi project, it's a additional work.
2, docs-tmp worked as a middle site role, it used to generate /newsite-content site, it can be removed.
3, Here is my plan

  • Optimize the new website content based on feedback.
  • Remove docs-tmp
  • Replace old site docs with new docs.
  • Generate site based on new docs && Replace old content with new content.

Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR lgtm. Will merge shortly..

Could we do the follow on changes in this way

  • 1 pr to remove docs-tmp
  • 1 pr to remove old docs (leaving the site as-is)
  • 1 pr to update the site content with new content only..

@vinothchandar vinothchandar merged commit f7c8c32 into apache:asf-site Jan 12, 2020
@lamberken
Copy link
Member Author

This PR lgtm. Will merge shortly..

Could we do the follow on changes in this way

  • 1 pr to remove docs-tmp
  • 1 pr to remove old docs (leaving the site as-is)
  • 1 pr to update the site content with new content only..

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants