-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-506] Optimize the new website based on feedback #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vinothchandar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lamber-ken seems like this PR also deletes/moves a lot more files? can you please describe all the changes here in the PR.. Also could you please scope this PR to just update on the *md files? (without the generated html content).. That will help review more incrementally... its just a very large PR to chew and I am having a hard time understanding how the 3 things you describe in changelog can cause such a large change
|
hi @vinothchandar, thanks for your review. I cleaned old site and tmp site files. |
|
hi @vinothchandar, thanks for your advice, all review comments are addressed and fixed. |
vinothchandar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is just fixing a new things for new site and also porting over the chinese pages from old site? How does this work relate to the apachecn page?
Side note: What purpose does docs-tmp solve.. We should make a plan to retire the old site and switch over to the new one early next week.. can you please outline the steps needed for that in a separate JIRA and we hash out a plan first.
Hi, @vinothchandar 1, ApacheCN page can help to promote hudi project, it's a additional work.
|
vinothchandar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR lgtm. Will merge shortly..
Could we do the follow on changes in this way
- 1 pr to remove
docs-tmp - 1 pr to remove old
docs(leaving the site as-is) - 1 pr to update the site content with new content only..
Got it. |

What is the purpose of the pull request
Feedback Record #1196 .
Quick review, please visit https://lamber-ken.github.io .
Worked with ApacheCN, finished the work of chinese translation, please visit https://hudi.apachecn.org/docs/0.5.0 .
Brief change log
Verify this pull request
This pull request is optimize work on the new website.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.