[HUDI-8238] Skip this log file instead of skipping all log files #11973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… log file which is written later 1. Skip this log file instead of skipping all log files when scan a log file which is written later. Signed-off-by: TheR1sing3un <[email protected]>
TheR1sing3un
changed the title
Collaborator
yihua
reviewed
Sep 21, 2024
Contributor
yihua
left a comment
yihua
left a comment
There was a problem hiding this comment.
@TheR1sing3un Could you attach a JIRA ticket for tracking? This is not a minor change.
Contributor
|
This fix is related with data loss, we are addressing this issue cc @nsivabalan . |
Member
Author
Done~ issue: #11986 jira: https://issues.apache.org/jira/browse/HUDI-8238 |
TheR1sing3un
changed the title
Contributor
|
hey, I am also taking a stab at fixing this. Will share the link once I have the patch ready. |
Contributor
Member
Author
Great! Your fixing LGTM~ I will close this pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close issue: [SUPPORT] Missing logs in need when scan logs for mor snapshot read #11986
close jira: https://issues.apache.org/jira/browse/HUDI-8238
Change Logs
Skip this log file instead of skipping all log files when scan a log file which is written later
Describe context and summary for this change. Highlight if any code was copied.
Impact
none
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
low
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
none
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist